From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Felix Wu <flwu@google.com>
Cc: peter.maydell@linaro.org, pbonzini@redhat.com,
eduardo@habkost.net, peterx@redhat.com, david@redhat.com,
philmd@linaro.org, qemu-devel@nongnu.org,
Roman Kiryanov <rkir@google.com>
Subject: Re: [PATCH 1/2] qom: Rename Object::class into Object::klass
Date: Tue, 25 Jun 2024 08:15:26 +0100 [thread overview]
Message-ID: <ZnpujoT6gDFRP0ED@redhat.com> (raw)
In-Reply-To: <20240624204400.103747-1-flwu@google.com>
On Mon, Jun 24, 2024 at 08:43:59PM +0000, Felix Wu wrote:
> From: Roman Kiryanov <rkir@google.com>
>
> 'class' is a C++ keyword and it prevents from
> using the QEMU headers with a C++ compiler.
>
> Google-Bug-Id: 331190993
> Change-Id: I9ab7d2d77edef654a9c7b7cb9cd01795a6ed65a2
Please remove both of these lines when posting patches. They are
irrelevant to QEMU's git commit history.
> Signed-off-by: Felix Wu <flwu@google.com>
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> hw/core/qdev-properties-system.c | 2 +-
> include/exec/memory.h | 2 +-
> include/qom/object.h | 2 +-
> qom/object.c | 90 ++++++++++++++++----------------
> 4 files changed, 48 insertions(+), 48 deletions(-)
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2024-06-25 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 20:43 [PATCH 1/2] qom: Rename Object::class into Object::klass Felix Wu
2024-06-24 20:44 ` [PATCH 2/2] include/qom: Rename typename into type_name Felix Wu
2024-06-25 2:20 ` [PATCH 1/2] qom: Rename Object::class into Object::klass Philippe Mathieu-Daudé
2024-06-25 9:23 ` Peter Maydell
2024-06-25 9:36 ` Daniel P. Berrangé
2024-06-25 7:15 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnpujoT6gDFRP0ED@redhat.com \
--to=berrange@redhat.com \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=flwu@google.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).