From: Peter Xu <peterx@redhat.com>
To: Yichen Wang <yichen.wang@bytedance.com>
Cc: "Fabiano Rosas" <farosas@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
qemu-devel@nongnu.org, "Hao Xiang" <hao.xiang@linux.dev>,
"Liu, Yuan1" <yuan1.liu@intel.com>,
"Zou, Nanhai" <nanhai.zou@intel.com>,
"Ho-Ren (Jack) Chuang" <horenchuang@bytedance.com>
Subject: Re: [PATCH v5 0/5] Implement QATzip compression method
Date: Thu, 11 Jul 2024 11:44:51 -0400 [thread overview]
Message-ID: <Zo_98z3zmbDM1H40@x1n> (raw)
In-Reply-To: <20240711025229.66260-1-yichen.wang@bytedance.com>
On Wed, Jul 10, 2024 at 07:52:24PM -0700, Yichen Wang wrote:
> v5:
> - Rebase changes on top of 59084feb256c617063e0dbe7e64821ae8852d7cf
> - Add documentations about migration with qatzip accerlation
> - Remove multifd-qatzip-sw-fallback option
I think Yuan provided quite a few meaningful comments, did you address all
of them?
You didn't reply in the previous version, and you didn't add anything in
the changelog. I suggest you at least do one of them in the future so that
reviewers can understand what happen.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2024-07-11 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 2:52 [PATCH v5 0/5] Implement QATzip compression method Yichen Wang
2024-07-11 2:52 ` [PATCH v5 1/5] docs/migration: add qatzip compression feature Yichen Wang
2024-07-11 2:52 ` [PATCH v5 2/5] meson: Introduce 'qatzip' feature to the build system Yichen Wang
2024-07-11 2:52 ` [PATCH v5 3/5] migration: Add migration parameters for QATzip Yichen Wang
2024-07-11 2:52 ` [PATCH v5 4/5] migration: Introduce 'qatzip' compression method Yichen Wang
2024-07-12 14:17 ` Fabiano Rosas
2024-07-14 5:53 ` [External] " Yichen Wang
2024-07-15 16:32 ` Fabiano Rosas
2024-07-11 2:52 ` [PATCH v5 5/5] tests/migration: Add integration test for " Yichen Wang
2024-07-11 14:23 ` Peter Xu
2024-07-11 16:45 ` [External] " Yichen Wang
2024-07-11 15:44 ` Peter Xu [this message]
2024-07-11 16:48 ` [External] Re: [PATCH v5 0/5] Implement QATzip " Yichen Wang
2024-07-11 19:36 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo_98z3zmbDM1H40@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=hao.xiang@linux.dev \
--cc=horenchuang@bytedance.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=nanhai.zou@intel.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=yichen.wang@bytedance.com \
--cc=yuan1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).