qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Tyrone Ting" <kfting@nuvoton.com>,
	"Bin Meng" <bmeng.cn@gmail.com>, "Hao Wu" <wuhaotsh@google.com>,
	"Francisco Iglesias" <francisco.iglesias@amd.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	qemu-arm@nongnu.org, "Joel Stanley" <joel@jms.id.au>,
	"Sai Pavan Boddu" <sai.pavan.boddu@amd.com>,
	devel@lists.libvirt.org, "Luc Michel" <luc.michel@amd.com>,
	"Cédric Le Goater" <clg@redhat.com>
Subject: Re: [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)
Date: Thu, 11 Jul 2024 10:10:39 -0400	[thread overview]
Message-ID: <Zo_n39Vusyy-O_48@x1n> (raw)
In-Reply-To: <87plrkdpd7.fsf@suse.de>

On Thu, Jul 11, 2024 at 10:34:12AM -0300, Fabiano Rosas wrote:
> Is there an easy way to look at a field and tell in which machine type's
> timeframe it was introduced?

I am not aware of any.

> If the machine type of that era has been removed, then the field is free
> to go as well. I'd prefer if we had a hard link instead of just counting
> years. Maybe we should to that mapping at the machine deprecation time?
> As in, "look at the unused fields introduced in that timeframe and mark
> them free".

We can do that, but depending on how easy it would be. That can be an
overkill to me if it's non-trivial.  When it becomes complicated, I'd
rather make machine compat property easier to use so we always stick with
that.  Currently it's not as easy to use.

Maybe we shouldn't make it a common rule to let people reuse the UNUSED
fields, even if in this case it's probably fine?

E.g. I don't think it's a huge deal to keep all UNUSED fields forever -
sending 512B zeros for only one specific device isn't an issue even if kept
forever.

If "over 6 years" would be okay and simple enough, then maybe we can stick
with that (and only if people would like to reuse a field and ask; that's
after all not required..).  If more than that I doubt whether we should
spend time working on covering all the fields.

-- 
Peter Xu



  reply	other threads:[~2024-07-11 14:11 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 16:22 [PATCH v3 00/17] hw/sd/sdcard: Accumulation of cleanups and fixes Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 01/17] hw/sd/sdcard: Deprecate support for spec v1.10 Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 02/17] hw/sd/sdcard: Use spec v3.01 by default Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 03/17] hw/sd/sdcard: Track last command used to help logging Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 04/17] hw/sd/sdcard: Trace block offset in READ/WRITE data accesses Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 05/17] hw/sd/sdcard: Trace requested address computed by sd_req_get_address() Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56) Philippe Mathieu-Daudé
2024-07-09 20:38   ` Fabiano Rosas
2024-07-09 21:01     ` Peter Xu
2024-07-10 14:08       ` Fabiano Rosas
2024-07-10 15:01         ` Peter Xu
2024-07-10 16:21           ` Fabiano Rosas
2024-07-10 19:13             ` Peter Xu
2024-07-10 19:48               ` Fabiano Rosas
2024-07-10 20:11                 ` Peter Xu
2024-07-10 21:38                   ` Fabiano Rosas
2024-07-10 22:06                     ` Peter Xu
2024-07-11 13:34                       ` Fabiano Rosas
2024-07-11 14:10                         ` Peter Xu [this message]
2024-07-11 14:44                           ` Fabiano Rosas
2024-07-11 14:56                             ` Peter Xu
2024-07-11 15:03                               ` Fabiano Rosas
2024-06-27 16:22 ` [PATCH v3 07/17] hw/sd/sdcard: Send WRITE_PROT bits MSB first (CMD30) Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 08/17] hw/sd/sdcard: Send NUM_WR_BLOCKS bits MSB first (ACMD22) Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 09/17] hw/sd/sdcard: Use READY_FOR_DATA definition instead of magic value Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 10/17] hw/sd/sdcard: Assign SDCardStates enum values Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 11/17] hw/sd/sdcard: Simplify sd_inactive_state handling Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 12/17] hw/sd/sdcard: Restrict SWITCH_FUNCTION to sd_transfer_state (CMD6) Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 13/17] hw/sd/sdcard: Add direct reference to SDProto in SDState Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 14/17] hw/sd/sdcard: Extract sd_blk_len() helper Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 15/17] tests/qtest: Disable npcm7xx_sdhci tests using hardcoded RCA Philippe Mathieu-Daudé
2024-06-27 16:47   ` Thomas Huth
2024-06-27 17:19     ` Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 16/17] hw/sd/sdcard: Generate random RCA value Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 17/17] hw/sd/sdcard: Introduce definitions for EXT_CSD register Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zo_n39Vusyy-O_48@x1n \
    --to=peterx@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=clg@kaod.org \
    --cc=clg@redhat.com \
    --cc=devel@lists.libvirt.org \
    --cc=farosas@suse.de \
    --cc=francisco.iglesias@amd.com \
    --cc=joel@jms.id.au \
    --cc=kfting@nuvoton.com \
    --cc=luc.michel@amd.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sai.pavan.boddu@amd.com \
    --cc=thuth@redhat.com \
    --cc=wuhaotsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).