From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB7DCC3DA59 for ; Tue, 16 Jul 2024 19:47:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTo84-0002GM-At; Tue, 16 Jul 2024 15:46:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTo82-0002FZ-G7 for qemu-devel@nongnu.org; Tue, 16 Jul 2024 15:46:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTo7z-0004E9-JT for qemu-devel@nongnu.org; Tue, 16 Jul 2024 15:46:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721159182; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VvfpbyafhHJXpoqlHHNlren4NPD5yskeZx7TFXbqdgQ=; b=RTTo4Vq+6ai7cRX6fZayqwTgNDiz6wfJpJLeGwj241UjEpa900V2jOnh16xK1zvNn5a32Z DfNVTNPe0QoE2NlNJfcYYBEa+pLHyq8GfDds819B6c9ISTeR+vx4nExKHHC5I4Zptripjc 8oujpZoyEJPX9aZlc4n007PrjCwxsIA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453--_Pg8lD4NAOXoo6cl8Yi8g-1; Tue, 16 Jul 2024 15:46:18 -0400 X-MC-Unique: -_Pg8lD4NAOXoo6cl8Yi8g-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 809D91955F77; Tue, 16 Jul 2024 19:46:16 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.46]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 65E89300018F; Tue, 16 Jul 2024 19:46:13 +0000 (UTC) Date: Tue, 16 Jul 2024 20:46:09 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: John Snow , Thomas Huth , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Ani Sinha , Richard Henderson Subject: Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests Message-ID: References: <20240711115546.40859-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jul 16, 2024 at 09:34:41PM +0200, Paolo Bonzini wrote: > Il mar 16 lug 2024, 20:10 Daniel P. Berrangé ha > scritto: > > > On Tue, Jul 16, 2024 at 08:03:54PM +0200, Paolo Bonzini wrote: > > > Il mar 16 lug 2024, 18:45 John Snow ha scritto: > > > > > > > My only ask is that we keep the tests running in the custom venv > > > > environment we set up at build time > > > > > > > > > > Yes, they do, however pytest should also be added to pythondeps.toml if > > we > > > go this way. > > > > Done in this patch: > > > > https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg03596.html > > > That adds pycotap, not pytest. Yep, the next posting of this series uses only pycotap, there's no need for using pytest at all, as meson can be the harness directly when we emit TAP format. > > Yep, that's the part that I am a bit more doubtful about. > > > > Pulling & caching VM images isn't much more than a URL download to > > a local file, not very complex in python. Assuming that's what you > > are refering to, then it is already done in this patch: > > > > https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg03598.html > > > I think there are also compressed assets that have to be passed through > gzip/xzip/zstd. I am worried that Thomas's patches do 90% of the job but > that is not a good estimation of what's left. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|