qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Ed Maste" <emaste@freebsd.org>, "Li-Wen Hsu" <lwhsu@freebsd.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 1/2] ci: add gtk-vnc to the deps
Date: Thu, 18 Jul 2024 11:35:46 +0100	[thread overview]
Message-ID: <ZpjwAoqPF73tBRh5@redhat.com> (raw)
In-Reply-To: <c1c108af-9f7c-4bb1-bfd4-df3586534e3c@redhat.com>

On Thu, Jul 18, 2024 at 12:34:13PM +0200, Thomas Huth wrote:
> On 18/07/2024 11.41, Daniel P. Berrangé wrote:
> > The gtk-vnc package is used by the vnc-display-test qtest
> > program. Technically only gvnc is needed, but since we
> > already pull in the gtk3 dep, it is harmless to depend
> > on gtk-vnc.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >   tests/lcitool/projects/qemu.yml | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml
> > index 0c85784259..252e871f80 100644
> > --- a/tests/lcitool/projects/qemu.yml
> > +++ b/tests/lcitool/projects/qemu.yml
> > @@ -32,6 +32,7 @@ packages:
> >    - glusterfs
> >    - gnutls
> >    - gtk3
> > + - gtk-vnc
> >    - hostname
> >    - json-c
> >    - libaio
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
> IIRC Alex has a patch in his queue already to refresh the docker images,
> maybe he could include this change there, too...?

Yep, I included patch 2 just for completeness, assuming Alex would
just pick patch 1, and then re-generate.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2024-07-18 10:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18  9:41 [PATCH 0/2] ci: fix running of vnc-display-test Daniel P. Berrangé
2024-07-18  9:41 ` [PATCH 1/2] ci: add gtk-vnc to the deps Daniel P. Berrangé
2024-07-18 10:34   ` Thomas Huth
2024-07-18 10:35     ` Daniel P. Berrangé [this message]
2024-07-18  9:41 ` [PATCH 2/2] ci: refresh package lists with lcitool Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZpjwAoqPF73tBRh5@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=emaste@freebsd.org \
    --cc=lwhsu@freebsd.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).