* Re: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic
2024-07-25 14:51 [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic Salil Mehta via
@ 2024-07-25 19:57 ` Philippe Mathieu-Daudé
2024-07-26 0:27 ` Gavin Shan
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-07-25 19:57 UTC (permalink / raw)
To: Salil Mehta, qemu-devel, qemu-arm, mst, peter.maydell
Cc: maz, jean-philippe, jonathan.cameron, lpieralisi,
richard.henderson, imammedo, andrew.jones, david, eric.auger,
oliver.upton, pbonzini, will, gshan, rafael, alex.bennee, linux,
darren, ilkka, vishnu, karl.heubaum, miguel.luis, salil.mehta,
zhukeqian1, wangxiongfeng2, wangyanan55, jiakernel2, maobibo,
lixianglai, npiggin, harshpb, linuxarm
On 25/7/24 16:51, Salil Mehta wrote:
> Loop should exit prematurely on successfully finding out the parked vCPU (struct
> KVMParkedVcpu) in the 'struct KVMState' maintained 'kvm_parked_vcpus' list of
> parked vCPUs.
>
> Fixes: Coverity CID 1558552
> Fixes: 08c3286822 ("accel/kvm: Extract common KVM vCPU {creation,parking} code")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Message-ID: <CAFEAcA-3_d1c7XSXWkFubD-LsW5c5i95e6xxV09r2C9yGtzcdA@mail.gmail.com>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> ---
> accel/kvm/kvm-all.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic
2024-07-25 14:51 [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic Salil Mehta via
2024-07-25 19:57 ` Philippe Mathieu-Daudé
@ 2024-07-26 0:27 ` Gavin Shan
2024-07-26 8:47 ` Zhao Liu
2024-07-26 9:33 ` Igor Mammedov
3 siblings, 0 replies; 8+ messages in thread
From: Gavin Shan @ 2024-07-26 0:27 UTC (permalink / raw)
To: Salil Mehta, qemu-devel, qemu-arm, mst, peter.maydell
Cc: maz, jean-philippe, jonathan.cameron, lpieralisi,
richard.henderson, imammedo, andrew.jones, david, philmd,
eric.auger, oliver.upton, pbonzini, will, rafael, alex.bennee,
linux, darren, ilkka, vishnu, karl.heubaum, miguel.luis,
salil.mehta, zhukeqian1, wangxiongfeng2, wangyanan55, jiakernel2,
maobibo, lixianglai, npiggin, harshpb, linuxarm
On 7/26/24 12:51 AM, Salil Mehta wrote:
> Loop should exit prematurely on successfully finding out the parked vCPU (struct
> KVMParkedVcpu) in the 'struct KVMState' maintained 'kvm_parked_vcpus' list of
> parked vCPUs.
>
> Fixes: Coverity CID 1558552
> Fixes: 08c3286822 ("accel/kvm: Extract common KVM vCPU {creation,parking} code")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Message-ID: <CAFEAcA-3_d1c7XSXWkFubD-LsW5c5i95e6xxV09r2C9yGtzcdA@mail.gmail.com>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> ---
> accel/kvm/kvm-all.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Gavin Shan <gshan@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic
2024-07-25 14:51 [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic Salil Mehta via
2024-07-25 19:57 ` Philippe Mathieu-Daudé
2024-07-26 0:27 ` Gavin Shan
@ 2024-07-26 8:47 ` Zhao Liu
2024-07-26 9:33 ` Igor Mammedov
3 siblings, 0 replies; 8+ messages in thread
From: Zhao Liu @ 2024-07-26 8:47 UTC (permalink / raw)
To: Salil Mehta
Cc: qemu-devel, qemu-arm, mst, peter.maydell, maz, jean-philippe,
jonathan.cameron, lpieralisi, richard.henderson, imammedo,
andrew.jones, david, philmd, eric.auger, oliver.upton, pbonzini,
will, gshan, rafael, alex.bennee, linux, darren, ilkka, vishnu,
karl.heubaum, miguel.luis, salil.mehta, zhukeqian1,
wangxiongfeng2, wangyanan55, jiakernel2, maobibo, lixianglai,
npiggin, harshpb, linuxarm
On Thu, Jul 25, 2024 at 03:51:32PM +0100, Salil Mehta via wrote:
> Date: Thu, 25 Jul 2024 15:51:32 +0100
> From: Salil Mehta via <qemu-devel@nongnu.org>
> Subject: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark
> logic
> X-Mailer: git-send-email 2.34.1
>
> Loop should exit prematurely on successfully finding out the parked vCPU (struct
> KVMParkedVcpu) in the 'struct KVMState' maintained 'kvm_parked_vcpus' list of
> parked vCPUs.
>
> Fixes: Coverity CID 1558552
> Fixes: 08c3286822 ("accel/kvm: Extract common KVM vCPU {creation,parking} code")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Message-ID: <CAFEAcA-3_d1c7XSXWkFubD-LsW5c5i95e6xxV09r2C9yGtzcdA@mail.gmail.com>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> ---
> accel/kvm/kvm-all.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic
2024-07-25 14:51 [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic Salil Mehta via
` (2 preceding siblings ...)
2024-07-26 8:47 ` Zhao Liu
@ 2024-07-26 9:33 ` Igor Mammedov
2024-07-31 8:48 ` Salil Mehta via
3 siblings, 1 reply; 8+ messages in thread
From: Igor Mammedov @ 2024-07-26 9:33 UTC (permalink / raw)
To: Salil Mehta
Cc: qemu-devel, qemu-arm, mst, peter.maydell, maz, jean-philippe,
jonathan.cameron, lpieralisi, richard.henderson, andrew.jones,
david, philmd, eric.auger, oliver.upton, pbonzini, will, gshan,
rafael, alex.bennee, linux, darren, ilkka, vishnu, karl.heubaum,
miguel.luis, salil.mehta, zhukeqian1, wangxiongfeng2, wangyanan55,
jiakernel2, maobibo, lixianglai, npiggin, harshpb, linuxarm
On Thu, 25 Jul 2024 15:51:32 +0100
Salil Mehta <salil.mehta@huawei.com> wrote:
> Loop should exit prematurely on successfully finding out the parked vCPU (struct
> KVMParkedVcpu) in the 'struct KVMState' maintained 'kvm_parked_vcpus' list of
> parked vCPUs.
>
> Fixes: Coverity CID 1558552
> Fixes: 08c3286822 ("accel/kvm: Extract common KVM vCPU {creation,parking} code")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Message-ID: <CAFEAcA-3_d1c7XSXWkFubD-LsW5c5i95e6xxV09r2C9yGtzcdA@mail.gmail.com>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> accel/kvm/kvm-all.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index 0aa4b4624a..c181297f00 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -362,6 +362,7 @@ int kvm_unpark_vcpu(KVMState *s, unsigned long vcpu_id)
> QLIST_REMOVE(cpu, node);
> kvm_fd = cpu->kvm_fd;
> g_free(cpu);
> + break;
> }
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic
2024-07-26 9:33 ` Igor Mammedov
@ 2024-07-31 8:48 ` Salil Mehta via
2024-07-31 11:39 ` Peter Maydell
0 siblings, 1 reply; 8+ messages in thread
From: Salil Mehta via @ 2024-07-31 8:48 UTC (permalink / raw)
To: Igor Mammedov, Michael S. Tsirkin, peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, mst@redhat.com,
peter.maydell@linaro.org, maz@kernel.org,
jean-philippe@linaro.org, Jonathan Cameron, lpieralisi@kernel.org,
richard.henderson@linaro.org, andrew.jones@linux.dev,
david@redhat.com, philmd@linaro.org, eric.auger@redhat.com,
oliver.upton@linux.dev, pbonzini@redhat.com, will@kernel.org,
gshan@redhat.com, rafael@kernel.org, alex.bennee@linaro.org,
linux@armlinux.org.uk, darren@os.amperecomputing.com,
ilkka@os.amperecomputing.com, vishnu@os.amperecomputing.com,
karl.heubaum@oracle.com, miguel.luis@oracle.com,
salil.mehta@opnsrc.net, zhukeqian, wangxiongfeng (C),
wangyanan (Y), jiakernel2@gmail.com, maobibo@loongson.cn,
lixianglai@loongson.cn, npiggin@gmail.com, harshpb@linux.ibm.com,
Linuxarm
Hello,
A quick check and a gentle reminder, has this patch been accepted?
Best regards
Salil.
> From: Igor Mammedov <imammedo@redhat.com>
> Sent: Friday, July 26, 2024 10:34 AM
> To: Salil Mehta <salil.mehta@huawei.com>
>
> On Thu, 25 Jul 2024 15:51:32 +0100
> Salil Mehta <salil.mehta@huawei.com> wrote:
>
> > Loop should exit prematurely on successfully finding out the parked
> > vCPU (struct
> > KVMParkedVcpu) in the 'struct KVMState' maintained
> 'kvm_parked_vcpus'
> > list of parked vCPUs.
> >
> > Fixes: Coverity CID 1558552
> > Fixes: 08c3286822 ("accel/kvm: Extract common KVM vCPU
> > {creation,parking} code")
> > Reported-by: Peter Maydell <peter.maydell@linaro.org>
> > Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> > Message-ID:
> > <CAFEAcA-3_d1c7XSXWkFubD-
> LsW5c5i95e6xxV09r2C9yGtzcdA@mail.gmail.com>
> > Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
> > ---
> > accel/kvm/kvm-all.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index
> > 0aa4b4624a..c181297f00 100644
> > --- a/accel/kvm/kvm-all.c
> > +++ b/accel/kvm/kvm-all.c
> > @@ -362,6 +362,7 @@ int kvm_unpark_vcpu(KVMState *s, unsigned long
> vcpu_id)
> > QLIST_REMOVE(cpu, node);
> > kvm_fd = cpu->kvm_fd;
> > g_free(cpu);
> > + break;
> > }
> > }
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic
2024-07-31 8:48 ` Salil Mehta via
@ 2024-07-31 11:39 ` Peter Maydell
2024-07-31 12:32 ` Salil Mehta via
0 siblings, 1 reply; 8+ messages in thread
From: Peter Maydell @ 2024-07-31 11:39 UTC (permalink / raw)
To: Salil Mehta
Cc: Igor Mammedov, Michael S. Tsirkin, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, mst@redhat.com, maz@kernel.org,
jean-philippe@linaro.org, Jonathan Cameron, lpieralisi@kernel.org,
richard.henderson@linaro.org, andrew.jones@linux.dev,
david@redhat.com, philmd@linaro.org, eric.auger@redhat.com,
oliver.upton@linux.dev, pbonzini@redhat.com, will@kernel.org,
gshan@redhat.com, rafael@kernel.org, alex.bennee@linaro.org,
linux@armlinux.org.uk, darren@os.amperecomputing.com,
ilkka@os.amperecomputing.com, vishnu@os.amperecomputing.com,
karl.heubaum@oracle.com, miguel.luis@oracle.com,
salil.mehta@opnsrc.net, zhukeqian, wangxiongfeng (C),
wangyanan (Y), jiakernel2@gmail.com, maobibo@loongson.cn,
lixianglai@loongson.cn, npiggin@gmail.com, harshpb@linux.ibm.com,
Linuxarm
On Wed, 31 Jul 2024 at 09:49, Salil Mehta <salil.mehta@huawei.com> wrote:
>
> Hello,
>
> A quick check and a gentle reminder, has this patch been accepted?
Thanks for the ping. I'm doing a target-arm pullreq tomorrow
so I'll take it via my queue.
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic
2024-07-31 11:39 ` Peter Maydell
@ 2024-07-31 12:32 ` Salil Mehta via
0 siblings, 0 replies; 8+ messages in thread
From: Salil Mehta via @ 2024-07-31 12:32 UTC (permalink / raw)
To: Peter Maydell
Cc: Igor Mammedov, Michael S. Tsirkin, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, mst@redhat.com, maz@kernel.org,
jean-philippe@linaro.org, Jonathan Cameron, lpieralisi@kernel.org,
richard.henderson@linaro.org, andrew.jones@linux.dev,
david@redhat.com, philmd@linaro.org, eric.auger@redhat.com,
oliver.upton@linux.dev, pbonzini@redhat.com, will@kernel.org,
gshan@redhat.com, rafael@kernel.org, alex.bennee@linaro.org,
linux@armlinux.org.uk, darren@os.amperecomputing.com,
ilkka@os.amperecomputing.com, vishnu@os.amperecomputing.com,
karl.heubaum@oracle.com, miguel.luis@oracle.com,
salil.mehta@opnsrc.net, zhukeqian, wangxiongfeng (C),
wangyanan (Y), jiakernel2@gmail.com, maobibo@loongson.cn,
lixianglai@loongson.cn, npiggin@gmail.com, harshpb@linux.ibm.com,
Linuxarm
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Wednesday, July 31, 2024 12:39 PM
> To: Salil Mehta <salil.mehta@huawei.com>
>
> On Wed, 31 Jul 2024 at 09:49, Salil Mehta <salil.mehta@huawei.com> wrote:
> >
> > Hello,
> >
> > A quick check and a gentle reminder, has this patch been accepted?
>
> Thanks for the ping. I'm doing a target-arm pullreq tomorrow so I'll take it via
> my queue.
Great. Thanks!
Best regards
Salil.
>
> -- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread