Re: [PATCH 13/18] qapi/crypto: Rename QCryptoIVGenAlgorithm to *Algo, and drop prefix

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Jul 30, 2024 at 10:10:27AM +0200, Markus Armbruster wrote:
> QAPI's 'prefix' feature can make the connection between enumeration
> type and its constants less than obvious.  It's best used with
> restraint.
> 
> QCryptoIVGenAlgorithm has a 'prefix' that overrides the generated
> enumeration constants' prefix to QCRYPTO_IVGEN_ALG.
> 
> We could simply drop 'prefix', but then the prefix becomes
> QCRYPTO_IV_GEN_ALGORITHM, which is rather long.
> 
> We could additionally rename the type to QCryptoIVGenAlg, but I think
> the abbreviation "alg" is less than clear.
> 
> Rename the type to QCryptoIVGenAlgo instead.  The prefix becomes
> QCRYPTO_IV_GEN_ALGO.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/crypto.json               |  9 ++++-----
>  crypto/ivgenpriv.h             |  2 +-
>  include/crypto/ivgen.h         | 14 +++++++-------
>  crypto/block-luks.c            | 16 ++++++++--------
>  crypto/block-qcow.c            |  2 +-
>  crypto/ivgen.c                 | 10 +++++-----
>  tests/unit/test-crypto-block.c | 14 +++++++-------
>  tests/unit/test-crypto-ivgen.c | 22 +++++++++++-----------
>  8 files changed, 44 insertions(+), 45 deletions(-)

Acked-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|