From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C41F1C3DA4A for ; Thu, 1 Aug 2024 09:22:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZS0J-0005w9-OC; Thu, 01 Aug 2024 05:21:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZS0E-0005sX-UT; Thu, 01 Aug 2024 05:21:44 -0400 Received: from mgamail.intel.com ([198.175.65.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZS0B-0002Y2-7n; Thu, 01 Aug 2024 05:21:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722504100; x=1754040100; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Xmg/968fCVUCGZYT797Z9jjQKkMZwiEQFs2Df4qxxrw=; b=nEcp1w3nT5VQZ2QHfj2l4eDQLHofZ8tM+TQhWqw280p/bEr3IDd11+ng GDJ/WRSmT9NO6bG9P5PQ9MM7fMxMnTfjOiJWOzm8sOUAUM/Qwmw0RFVzs LpUClwnO287DM5DJMAv1EJe6vyl7N+PKNZAHyIXenbLXLVcPqRx5yxv62 n3+rhdwuIjVBTWdlnyyohdP7EyjdYykZ1U7fhxsy/C+axE6ucNfhXG3m+ yknJvSiyK/IRlS62lJ2/AtrIM0g26sj5/PEy24+Th82btwaI3ccl7Nn3U nOBKGVFVuQjRoSJuuPHK3uPFTd1cQKtmtsDerXc1XzDBtkFvGBZQkfLPc w==; X-CSE-ConnectionGUID: 0sCktYJQQlOAapkoS+KQWQ== X-CSE-MsgGUID: dUOJ9P98SeufBIFaO9mLAQ== X-IronPort-AV: E=McAfee;i="6700,10204,11150"; a="20385178" X-IronPort-AV: E=Sophos;i="6.09,254,1716274800"; d="scan'208";a="20385178" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2024 02:21:21 -0700 X-CSE-ConnectionGUID: D84dmaN6SuK0K8x9jJDrlw== X-CSE-MsgGUID: YCFLQ0uPTG+Bm5RJ5hwSpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,254,1716274800"; d="scan'208";a="59787927" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.36]) by orviesa005.jf.intel.com with ESMTP; 01 Aug 2024 02:21:16 -0700 Date: Thu, 1 Aug 2024 17:37:03 +0800 From: Zhao Liu To: Markus Armbruster Cc: Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , Eduardo Habkost , Marcel Apfelbaum , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Yanan Wang , "Michael S . Tsirkin" , Paolo Bonzini , Richard Henderson , Eric Blake , Marcelo Tosatti , Alex =?iso-8859-1?Q?Benn=E9e?= , Peter Maydell , Jonathan Cameron , Sia Jee Heng , qemu-devel@nongnu.org, kvm@vger.kernel.org, qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Zhenyu Wang , Dapeng Mi , Yongwei Ma Subject: Re: [PATCH 8/8] qemu-options: Add the description of smp-cache object Message-ID: References: <20240704031603.1744546-1-zhao1.liu@intel.com> <20240704031603.1744546-9-zhao1.liu@intel.com> <87r0bl35ug.fsf@pond.sub.org> <87bk2nnev2.fsf@pond.sub.org> <87le1psuv3.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87le1psuv3.fsf@pond.sub.org> Received-SPF: pass client-ip=198.175.65.21; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.126, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Jul 25, 2024 at 11:07:12AM +0200, Markus Armbruster wrote: > Date: Thu, 25 Jul 2024 11:07:12 +0200 > From: Markus Armbruster > Subject: Re: [PATCH 8/8] qemu-options: Add the description of smp-cache > object > > Zhao Liu writes: > > > Hi Markus and Daniel, > > > > I have the questions about the -object per cache implementation: > > > > On Wed, Jul 24, 2024 at 02:39:29PM +0200, Markus Armbruster wrote: > >> Date: Wed, 24 Jul 2024 14:39:29 +0200 > >> From: Markus Armbruster > >> Subject: Re: [PATCH 8/8] qemu-options: Add the description of smp-cache > >> object > >> > >> Zhao Liu writes: > >> > >> > Hi Markus, > >> > > >> > On Mon, Jul 22, 2024 at 03:37:43PM +0200, Markus Armbruster wrote: > >> >> Date: Mon, 22 Jul 2024 15:37:43 +0200 > >> >> From: Markus Armbruster > >> >> Subject: Re: [PATCH 8/8] qemu-options: Add the description of smp-cache > >> >> object > >> >> > >> >> Zhao Liu writes: > >> >> > >> >> > Signed-off-by: Zhao Liu > >> >> > >> >> This patch is just documentation. The code got added in some previous > >> >> patch. Would it make sense to squash this patch into that previous > >> >> patch? > >> > > >> > OK, I'll merge them. > >> > > >> >> > --- > >> >> > Changes since RFC v2: > >> >> > * Rewrote the document of smp-cache object. > >> >> > > >> >> > Changes since RFC v1: > >> >> > * Use "*_cache=topo_level" as -smp example as the original "level" > >> >> > term for a cache has a totally different meaning. (Jonathan) > >> >> > --- > >> >> > qemu-options.hx | 58 +++++++++++++++++++++++++++++++++++++++++++++++++ > >> >> > 1 file changed, 58 insertions(+) > >> >> > > >> >> > diff --git a/qemu-options.hx b/qemu-options.hx > >> >> > index 8ca7f34ef0c8..4b84f4508a6e 100644 > >> >> > --- a/qemu-options.hx > >> >> > +++ b/qemu-options.hx > >> >> > @@ -159,6 +159,15 @@ SRST > >> >> > :: > >> >> > > >> >> > -machine cxl-fmw.0.targets.0=cxl.0,cxl-fmw.0.targets.1=cxl.1,cxl-fmw.0.size=128G,cxl-fmw.0.interleave-granularity=512 > >> >> > + > >> >> > + ``smp-cache='id'`` > >> >> > + Allows to configure cache property (now only the cache topology level). > >> >> > + > >> >> > + For example: > >> >> > + :: > >> >> > + > >> >> > + -object '{"qom-type":"smp-cache","id":"cache","caches":[{"name":"l1d","topo":"core"},{"name":"l1i","topo":"core"},{"name":"l2","topo":"module"},{"name":"l3","topo":"die"}]}' > >> >> > + -machine smp-cache=cache > >> >> > ERST > >> >> > > >> >> > DEF("M", HAS_ARG, QEMU_OPTION_M, > >> >> > @@ -5871,6 +5880,55 @@ SRST > >> >> > :: > >> >> > > >> >> > (qemu) qom-set /objects/iothread1 poll-max-ns 100000 > >> >> > + > >> >> > + ``-object '{"qom-type":"smp-cache","id":id,"caches":[{"name":cache_name,"topo":cache_topo}]}'`` > >> >> > + Create an smp-cache object that configures machine's cache > >> >> > + property. Currently, cache property only include cache topology > >> >> > + level. > >> >> > + > >> >> > + This option must be written in JSON format to support JSON list. > >> >> > >> >> Why? > >> > > >> > I'm not familiar with this, so I hope you could educate me if I'm wrong. > >> > > >> > All I know so far is for -object that defining a list can only be done in > >> > JSON format and not with a numeric index like a keyval based option, like: > >> > > >> > -object smp-cache,id=cache0,caches.0.name=l1i,caches.0.topo=core: Parameter 'caches' is missing > >> > > >> > the above doesn't work. > >> > > >> > Is there any other way to specify a list in command line? > >> > >> The command line is a big, sprawling mess :) > >> > >> -object supports either a JSON or a QemuOpts argument. *Not* keyval! > >> > >> Both QemuOpts and keyval parse something like KEY=VALUE,... Keyval > >> supports arrays and objects via dotted keys. QemuOpts doesn't natively > >> support arrays and objects, but its users can hack around that > >> limitation in various ways. -object doesn't. So you're right, it's > >> JSON or bust here. > >> > >> However, if we used one object per cache instead, we could get something > >> like > >> > >> -object smp-cache,name=l1d,... > >> -object smp-cache,name=l1u,... > >> -object smp-cache,name=l2,... > >> ... > > > > Current, I use -object to create a smp_cache object, and link it to > > MachineState by -machine,smp-cache=obj_id. > > > > Then for the objects per cache, how could I link them to machine? > > > > Is it possible that I create something static in smp_cache.c and expose > > all the cache information to machine through some interface? > > Good questions. However, before we head deeper into the weeds here, I > feel we should discuss the things below. And before we do that, I need > a clear understanding of the use case. Elsewhere in this thread, I just > described the use case as I understand it. Please reply there. I'll > then come back to this message. > > [...] Jonathan and I provided different use cases for x86 and Arm. Could we come back here to continue the discussion? :) Thanks, Zhao