From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH for-9.2] tests/qtest/migration: Remove vmstate-static-checker test
Date: Fri, 2 Aug 2024 11:34:18 -0400 [thread overview]
Message-ID: <Zqz8ejp7BLSQx8rQ@x1n> (raw)
In-Reply-To: <20240802145301.29629-1-farosas@suse.de>
On Fri, Aug 02, 2024 at 11:53:01AM -0300, Fabiano Rosas wrote:
> I fumbled one of my last pull requests when fixing in-tree an issue
> with commit 87d67fadb9 ("monitor: Stop removing non-duplicated
> fds"). Basically mixed-up my `git add -p` and `git checkout -p` and
> committed a piece of test infra that has not been reviewed yet.
>
> This has not caused any bad symptoms because the test is not enabled
> by default anywhere: make check doesn't use two qemu binaries and the
> CI doesn't have PYTHON set for the compat tests. Besides, the test
> works fine anyway, it would not break anything.
>
> Remove this because it was never intended to be merged.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
prev parent reply other threads:[~2024-08-02 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 14:53 [PATCH for-9.2] tests/qtest/migration: Remove vmstate-static-checker test Fabiano Rosas
2024-08-02 15:34 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zqz8ejp7BLSQx8rQ@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).