qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Amjad Alsharafi <amjadsharafi10@gmail.com>
Cc: qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
	"open list:vvfat" <qemu-block@nongnu.org>
Subject: Re: [PATCH v6 0/5] vvfat: Fix write bugs for large files and add iotests
Date: Mon, 5 Aug 2024 12:24:08 +0200	[thread overview]
Message-ID: <ZrCoSIBugqaEz4AH@redhat.com> (raw)
In-Reply-To: <cover.1721470238.git.amjadsharafi10@gmail.com>

Am 20.07.2024 um 12:13 hat Amjad Alsharafi geschrieben:
> These patches fix some bugs found when modifying files in vvfat.
> First, there was a bug when writing to the cluster 2 or above of a file, it
> will copy the cluster before it instead, so, when writing to cluster=2, the
> content of cluster=1 will be copied into disk instead in its place.
> 
> Another issue was modifying the clusters of a file and adding new
> clusters, this showed 2 issues:
> - If the new cluster is not immediately after the last cluster, it will
> cause issues when reading from this file in the future.
> - Generally, the usage of info.file.offset was incorrect, and the
> system would crash on abort() when the file is modified and a new
> cluster was added.
> 
> Also, added some iotests for vvfat, covering the this fix and also
> general behavior such as reading, writing, and creating files on the filesystem.
> Including tests for reading/writing the first cluster which
> would pass even before this patch.

Thanks, applied to the block branch (with patch 4 changed as indicated
in my comment there).

Kevin



      parent reply	other threads:[~2024-08-05 10:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-20 10:13 [PATCH v6 0/5] vvfat: Fix write bugs for large files and add iotests Amjad Alsharafi
2024-07-20 10:13 ` [PATCH v6 1/5] vvfat: Fix bug in writing to middle of file Amjad Alsharafi
2024-07-20 10:13 ` [PATCH v6 2/5] vvfat: Fix usage of `info.file.offset` Amjad Alsharafi
2024-07-20 10:13 ` [PATCH v6 3/5] vvfat: Fix wrong checks for cluster mappings invariant Amjad Alsharafi
2024-07-20 10:13 ` [PATCH v6 4/5] vvfat: Fix reading files with non-continuous clusters Amjad Alsharafi
2024-08-05 10:22   ` Kevin Wolf
2024-08-09  4:35     ` Amjad Alsharafi
2024-07-20 10:13 ` [PATCH v6 5/5] iotests: Add `vvfat` tests Amjad Alsharafi
2024-08-05 10:24 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrCoSIBugqaEz4AH@redhat.com \
    --to=kwolf@redhat.com \
    --cc=amjadsharafi10@gmail.com \
    --cc=hreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).