From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Michael Roth <michael.roth@amd.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths
Date: Wed, 7 Aug 2024 10:44:04 +0100 [thread overview]
Message-ID: <ZrNB5C7Ta-Qg-9HT@redhat.com> (raw)
In-Reply-To: <20240807093406.40360-1-philmd@linaro.org>
On Wed, Aug 07, 2024 at 11:34:06AM +0200, Philippe Mathieu-Daudé wrote:
> QAPI script generates headers under the qapi/ directory,
> so use this prefix in generated header paths, keeping
> all QAPI under the qapi/ namespace.
Err that's not always the case is it ?
For the main QMP schema, it generates under $BUILDDIR/qapi/,
but there are other schemas such as QGA, which is generated
under $BUILDDIR/qga/
It is confusing that we have both shared stuff and QMP schema
only stuff under the same location.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-08-07 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 9:34 [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths Philippe Mathieu-Daudé
2024-08-07 9:44 ` Daniel P. Berrangé [this message]
2024-08-07 10:50 ` Markus Armbruster
2024-08-07 11:00 ` Daniel P. Berrangé
2024-08-07 11:21 ` Markus Armbruster
2024-08-07 11:25 ` Daniel P. Berrangé
2024-08-07 12:01 ` Markus Armbruster
2024-08-07 12:09 ` Philippe Mathieu-Daudé
2024-08-08 8:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrNB5C7Ta-Qg-9HT@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).