* [PATCH] hw/i386/pc: Add a description for the i8042 property
@ 2024-08-12 17:23 Kamil Szczęk
2024-08-13 8:37 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kamil Szczęk @ 2024-08-12 17:23 UTC (permalink / raw)
To: qemu-devel@nongnu.org; +Cc: qemu-trivial@nongnu.org
While working on exposing the i8042 property in libvirt I noticed that
the property is missing a description. This adds a simple description
so that QEMU users don't have to dig in the source code to figure out
what this option does.
Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
---
hw/i386/pc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index c74931d577..defbc33125 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1807,6 +1807,8 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
object_class_property_add_bool(oc, PC_MACHINE_I8042,
pc_machine_get_i8042, pc_machine_set_i8042);
+ object_class_property_set_description(oc, PC_MACHINE_I8042,
+ "Enable/disable Intel 8042 PS/2 controller emulation");
object_class_property_add_bool(oc, "default-bus-bypass-iommu",
pc_machine_get_default_bus_bypass_iommu,
--
2.45.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hw/i386/pc: Add a description for the i8042 property
2024-08-12 17:23 [PATCH] hw/i386/pc: Add a description for the i8042 property Kamil Szczęk
@ 2024-08-13 8:37 ` Philippe Mathieu-Daudé
2024-08-13 9:32 ` Zhao Liu
2024-08-13 11:24 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-08-13 8:37 UTC (permalink / raw)
To: Kamil Szczęk, qemu-devel@nongnu.org; +Cc: qemu-trivial@nongnu.org
On 12/8/24 19:23, Kamil Szczęk wrote:
> While working on exposing the i8042 property in libvirt I noticed that
> the property is missing a description. This adds a simple description
> so that QEMU users don't have to dig in the source code to figure out
> what this option does.
>
> Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
> ---
> hw/i386/pc.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/i386/pc: Add a description for the i8042 property
2024-08-12 17:23 [PATCH] hw/i386/pc: Add a description for the i8042 property Kamil Szczęk
2024-08-13 8:37 ` Philippe Mathieu-Daudé
@ 2024-08-13 9:32 ` Zhao Liu
2024-08-13 11:24 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Zhao Liu @ 2024-08-13 9:32 UTC (permalink / raw)
To: Kamil Szczęk; +Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
On Mon, Aug 12, 2024 at 05:23:31PM +0000, Kamil Szczęk wrote:
> Date: Mon, 12 Aug 2024 17:23:31 +0000
> From: Kamil Szczęk <kamil@szczek.dev>
> Subject: [PATCH] hw/i386/pc: Add a description for the i8042 property
>
> While working on exposing the i8042 property in libvirt I noticed that
> the property is missing a description. This adds a simple description
> so that QEMU users don't have to dig in the source code to figure out
> what this option does.
>
> Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
> ---
> hw/i386/pc.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/i386/pc: Add a description for the i8042 property
2024-08-12 17:23 [PATCH] hw/i386/pc: Add a description for the i8042 property Kamil Szczęk
2024-08-13 8:37 ` Philippe Mathieu-Daudé
2024-08-13 9:32 ` Zhao Liu
@ 2024-08-13 11:24 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2024-08-13 11:24 UTC (permalink / raw)
To: Kamil Szczęk, qemu-devel@nongnu.org; +Cc: qemu-trivial@nongnu.org
On 8/12/24 19:23, Kamil Szczęk wrote:
> While working on exposing the i8042 property in libvirt I noticed that
> the property is missing a description. This adds a simple description
> so that QEMU users don't have to dig in the source code to figure out
> what this option does.
>
> Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
Queued, thanks.
Paolo
> ---
> hw/i386/pc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index c74931d577..defbc33125 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1807,6 +1807,8 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
>
> object_class_property_add_bool(oc, PC_MACHINE_I8042,
> pc_machine_get_i8042, pc_machine_set_i8042);
> + object_class_property_set_description(oc, PC_MACHINE_I8042,
> + "Enable/disable Intel 8042 PS/2 controller emulation");
>
> object_class_property_add_bool(oc, "default-bus-bypass-iommu",
> pc_machine_get_default_bus_bypass_iommu,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-13 11:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 17:23 [PATCH] hw/i386/pc: Add a description for the i8042 property Kamil Szczęk
2024-08-13 8:37 ` Philippe Mathieu-Daudé
2024-08-13 9:32 ` Zhao Liu
2024-08-13 11:24 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).