From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Clément Léger" <cleger@rivosinc.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH 2/2] qemu/osdep: handle sysconf(_SC_OPEN_MAX) return value == -1
Date: Fri, 30 Aug 2024 12:18:22 +0100 [thread overview]
Message-ID: <ZtGqfoaBkyEwJFvK@redhat.com> (raw)
In-Reply-To: <20240830111451.3799490-3-cleger@rivosinc.com>
On Fri, Aug 30, 2024 at 01:14:50PM +0200, Clément Léger wrote:
> On some systems (MacOS for instance), sysconf(_SC_OPEN_MAX) can return
> -1. In that case we should fallback to using the OPEN_MAX define.
> According to "man sysconf", the OPEN_MAX define should be present and
> provided by either unistd.h and/or limits.h so include them for that
> purpose. For other OSes, just assume a maximum of 1024 files descriptors
> as a fallback.
>
> Fixes: 4ec5ebea078e ("qemu/osdep: Move close_all_open_fds() to oslib-posix")
> Reported-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Clément Léger <cleger@rivosinc.com>
> ---
> util/oslib-posix.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-08-30 11:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 11:14 [PATCH 0/2] oslib: fix OSes support for qemu_close_all_open_fd() Clément Léger
2024-08-30 11:14 ` [PATCH 1/2] qemu/osdep: fix current process fds path for other OSes Clément Léger
2024-08-30 11:16 ` Daniel P. Berrangé
2024-08-30 11:31 ` Michael Tokarev
2024-08-30 11:14 ` [PATCH 2/2] qemu/osdep: handle sysconf(_SC_OPEN_MAX) return value == -1 Clément Léger
2024-08-30 11:18 ` Daniel P. Berrangé [this message]
2024-08-30 11:31 ` Michael Tokarev
2024-08-30 11:57 ` Clément Léger
2024-09-02 19:38 ` Philippe Mathieu-Daudé
2024-09-03 7:53 ` Clément Léger
2024-09-03 13:34 ` Philippe Mathieu-Daudé
2024-09-03 13:37 ` Clément Léger
2024-09-03 15:02 ` Philippe Mathieu-Daudé
2024-09-03 15:21 ` Daniel P. Berrangé
2024-09-03 17:56 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtGqfoaBkyEwJFvK@redhat.com \
--to=berrange@redhat.com \
--cc=cleger@rivosinc.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).