From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH] ci: migration: Don't run python tests in the compat job
Date: Thu, 5 Sep 2024 15:21:34 -0400 [thread overview]
Message-ID: <ZtoEvvdDO_3PsfDz@x1n> (raw)
In-Reply-To: <20240905185445.8179-1-farosas@suse.de>
On Thu, Sep 05, 2024 at 03:54:45PM -0300, Fabiano Rosas wrote:
> The vmstate-checker-script test has a bug that makes it flaky. It was
> also committed by mistake and will be removed.
>
> Since the migration-compat job takes the tests from the build-previous
> job instead of the current HEAD, neither a fix or a removal of the
> test will take effect for this release.
>
> Disable the faulty/undesirable test by taking advantage that it only
> runs if the PYTHON environment variable is set. This also disables the
> analyze-migration-script test, but this is fine because that test
> doesn't have migration compatibility implications.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
We should still merge your previous pull, right? Looks like that's the
easiest indeed.
But still, just to double check with both you and Peter on the merge plan.
If that's the case, I can send the 1st 9.2 pull earlier so we can have this
in.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2024-09-05 19:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 18:54 [PATCH] ci: migration: Don't run python tests in the compat job Fabiano Rosas
2024-09-05 19:05 ` Thomas Huth
2024-09-05 19:26 ` Peter Xu
2024-09-05 19:21 ` Peter Xu [this message]
2024-09-05 19:34 ` Fabiano Rosas
2024-09-05 19:54 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtoEvvdDO_3PsfDz@x1n \
--to=peterx@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=farosas@suse.de \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).