* [PATCH] tests/qtest/migration: Move a couple of slow tests under g_test_slow
@ 2024-09-11 14:52 Fabiano Rosas
2024-09-11 15:05 ` Peter Xu
0 siblings, 1 reply; 2+ messages in thread
From: Fabiano Rosas @ 2024-09-11 14:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Xu
The xbzrel and vcpu_dirty_limit are the two slowest tests from
migration-test. Move them under g_test_slow() to save about 40s per
run.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
tests/qtest/migration-test.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index d6768d5d71..814ec109a6 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -3803,8 +3803,10 @@ int main(int argc, char **argv)
migration_test_add("/migration/precopy/unix/plain",
test_precopy_unix_plain);
- migration_test_add("/migration/precopy/unix/xbzrle",
- test_precopy_unix_xbzrle);
+ if (g_test_slow()) {
+ migration_test_add("/migration/precopy/unix/xbzrle",
+ test_precopy_unix_xbzrle);
+ }
migration_test_add("/migration/precopy/file",
test_precopy_file);
migration_test_add("/migration/precopy/file/offset",
@@ -3979,7 +3981,7 @@ int main(int argc, char **argv)
if (g_str_equal(arch, "x86_64") && has_kvm && kvm_dirty_ring_supported()) {
migration_test_add("/migration/dirty_ring",
test_precopy_unix_dirty_ring);
- if (qtest_has_machine("pc")) {
+ if (qtest_has_machine("pc") && g_test_slow()) {
migration_test_add("/migration/vcpu_dirty_limit",
test_vcpu_dirty_limit);
}
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/qtest/migration: Move a couple of slow tests under g_test_slow
2024-09-11 14:52 [PATCH] tests/qtest/migration: Move a couple of slow tests under g_test_slow Fabiano Rosas
@ 2024-09-11 15:05 ` Peter Xu
0 siblings, 0 replies; 2+ messages in thread
From: Peter Xu @ 2024-09-11 15:05 UTC (permalink / raw)
To: Fabiano Rosas; +Cc: qemu-devel
On Wed, Sep 11, 2024 at 11:52:04AM -0300, Fabiano Rosas wrote:
> The xbzrel and vcpu_dirty_limit are the two slowest tests from
> migration-test. Move them under g_test_slow() to save about 40s per
> run.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
queued.
--
Peter Xu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-11 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-11 14:52 [PATCH] tests/qtest/migration: Move a couple of slow tests under g_test_slow Fabiano Rosas
2024-09-11 15:05 ` Peter Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).