From: Peter Xu <peterx@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Fabiano Rosas <farosas@suse.de>
Subject: Re: [PULL 3/6] migration/multifd: Fix loop conditions in multifd_zstd_send_prepare and multifd_zstd_recv
Date: Wed, 18 Sep 2024 09:17:50 -0400 [thread overview]
Message-ID: <ZurS_kvl2p5DlDqb@x1n> (raw)
In-Reply-To: <ee8a9fa5-1cb2-4094-9524-6f7b0d2f947d@weilnetz.de>
On Wed, Sep 18, 2024 at 07:47:42AM +0200, Stefan Weil wrote:
> Am 17.09.24 um 23:55 schrieb Peter Xu:
>
> > From: Stefan Weil via <qemu-devel@nongnu.org>
>
>
> How can I avoid that my author name/email is changed so often?
>
> Will this be fixed automatically before the commit is merged?
Hmm, this is pretty weird, as I actually did see this checkpatch error,
then I should have manually fixed the --author of your commit after queued,
as it was indeed mangled in the original patch:
https://lore.kernel.org/all/20240910054138.1458555-1-sw@weilnetz.de/
However it doesn't seem like working.. I checked again, that checkpatch
uses --no-mailmap so it still shows the mangled email.. I fixed it again
locally, then the error is gone.
Sorry, I don't know what happened, and why I used to fix it the same way
(that is, "git commit --author "XXX" --amend) but it didn't work last time
(but I guess .mailmap made it harder for me to recognize..).
It seems that we already have this:
commit 5204b499a6cae4dfd9fe762d5e6e82224892383b
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Thu Dec 8 16:55:35 2022 +0100
mailmap: Fix Stefan Weil author email
So I assume even if Peter applies this PR it'll still show correct.
However if you (or Peter, any of you) prefer me to resend a pull, I can do
that too. Let me know.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2024-09-18 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 21:55 [PULL 0/6] Migration 20240917 patches Peter Xu
2024-09-17 21:55 ` [PULL 1/6] tests/qtest/migration: Move a couple of slow tests under g_test_slow Peter Xu
2024-09-17 21:55 ` [PULL 2/6] migration/multifd: Fix build for qatzip Peter Xu
2024-09-17 21:55 ` [PULL 3/6] migration/multifd: Fix loop conditions in multifd_zstd_send_prepare and multifd_zstd_recv Peter Xu
2024-09-18 5:47 ` Stefan Weil via
2024-09-18 13:17 ` Peter Xu [this message]
2024-09-17 21:55 ` [PULL 4/6] softmmu/physmem.c: Keep transaction attribute in address_space_map() Peter Xu
2024-09-17 21:55 ` [PULL 5/6] migration/savevm: Remove extra load cleanup calls Peter Xu
2024-09-17 21:55 ` [PULL 6/6] migration/multifd: Fix rb->receivedmap cleanup race Peter Xu
2024-09-18 17:53 ` [PULL 0/6] Migration 20240917 patches Peter Maydell
2024-09-18 18:21 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZurS_kvl2p5DlDqb@x1n \
--to=peterx@redhat.com \
--cc=david@redhat.com \
--cc=farosas@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).