* of remote_iohub_finalize
@ 2024-09-18 17:00 Dr. David Alan Gilbert
2024-09-19 15:12 ` Jag Raman
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2024-09-18 17:00 UTC (permalink / raw)
To: jag.raman; +Cc: elena.ufimtseva, qemu-devel
Hi Jag,
One of my scripts noticed that 'remote_iohub_finalize' in
hw/remote/iohub.c is unused; before I go and delete it as deadcode,
is that actually just a missing call somewhere?
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: of remote_iohub_finalize
2024-09-18 17:00 of remote_iohub_finalize Dr. David Alan Gilbert
@ 2024-09-19 15:12 ` Jag Raman
2024-09-19 15:12 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Jag Raman @ 2024-09-19 15:12 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: Elena Ufimtseva, qemu-devel@nongnu.org
Hi Dave,
Thanks for checking!
remote_iohub_finalize() is a relic from when remote iohub was a separate type. We aren't calling it anywhere; we can remove it.
Cheers,
Jag
> On Sep 18, 2024, at 1:00 PM, Dr. David Alan Gilbert <dave@treblig.org> wrote:
>
> Hi Jag,
> One of my scripts noticed that 'remote_iohub_finalize' in
> hw/remote/iohub.c is unused; before I go and delete it as deadcode,
> is that actually just a missing call somewhere?
>
> Dave
>
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: of remote_iohub_finalize
2024-09-19 15:12 ` Jag Raman
@ 2024-09-19 15:12 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2024-09-19 15:12 UTC (permalink / raw)
To: Jag Raman; +Cc: Elena Ufimtseva, qemu-devel@nongnu.org
* Jag Raman (jag.raman@oracle.com) wrote:
> Hi Dave,
>
> Thanks for checking!
>
> remote_iohub_finalize() is a relic from when remote iohub was a separate type. We aren't calling it anywhere; we can remove it.
OK, I'll send a patch later.
Dave
> Cheers,
> Jag
>
> > On Sep 18, 2024, at 1:00 PM, Dr. David Alan Gilbert <dave@treblig.org> wrote:
> >
> > Hi Jag,
> > One of my scripts noticed that 'remote_iohub_finalize' in
> > hw/remote/iohub.c is unused; before I go and delete it as deadcode,
> > is that actually just a missing call somewhere?
> >
> > Dave
> >
> > --
> > -----Open up your eyes, open up your mind, open up your code -------
> > / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> > \ dave @ treblig.org | | In Hex /
> > \ _________________________|_____ http://www.treblig.org |_______/
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-19 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-18 17:00 of remote_iohub_finalize Dr. David Alan Gilbert
2024-09-19 15:12 ` Jag Raman
2024-09-19 15:12 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).