From: "Dr. David Alan Gilbert" <dave@treblig.org>
To: pbonzini@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu-timer: Remove unused qemu_clock_get_main_loop_timerlist
Date: Thu, 19 Sep 2024 14:42:43 +0000 [thread overview]
Message-ID: <Zuw4Y1VLDhjB7_hL@gallifrey> (raw)
In-Reply-To: <20240918163427.175237-1-dave@treblig.org>
* dave@treblig.org (dave@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> qemu_clock_get_main_loop_timerlist has been unused since it was
> originally added in
> ff83c66ecc ("aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
V2 sent, see:
[PATCH v2] qemu-timer: Remove unused timer functions
<20240919144124.309646-1-dave@treblig.org>
I found another one.
Dave
> ---
> include/qemu/timer.h | 10 ----------
> util/qemu-timer.c | 5 -----
> 2 files changed, 15 deletions(-)
>
> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> index fa56ec9481..ccd8578ae3 100644
> --- a/include/qemu/timer.h
> +++ b/include/qemu/timer.h
> @@ -190,16 +190,6 @@ bool qemu_clock_use_for_deadline(QEMUClockType type);
> */
> int64_t qemu_clock_deadline_ns_all(QEMUClockType type, int attr_mask);
>
> -/**
> - * qemu_clock_get_main_loop_timerlist:
> - * @type: the clock type
> - *
> - * Return the default timer list associated with a clock.
> - *
> - * Returns: the default timer list
> - */
> -QEMUTimerList *qemu_clock_get_main_loop_timerlist(QEMUClockType type);
> -
> /**
> * qemu_clock_nofify:
> * @type: the clock type
> diff --git a/util/qemu-timer.c b/util/qemu-timer.c
> index 213114be68..e5b5452e4e 100644
> --- a/util/qemu-timer.c
> +++ b/util/qemu-timer.c
> @@ -291,11 +291,6 @@ QEMUClockType timerlist_get_clock(QEMUTimerList *timer_list)
> return timer_list->clock->type;
> }
>
> -QEMUTimerList *qemu_clock_get_main_loop_timerlist(QEMUClockType type)
> -{
> - return main_loop_tlg.tl[type];
> -}
> -
> void timerlist_notify(QEMUTimerList *timer_list)
> {
> if (timer_list->notify_cb) {
> --
> 2.46.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
prev parent reply other threads:[~2024-09-19 14:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 16:34 [PATCH] qemu-timer: Remove unused qemu_clock_get_main_loop_timerlist dave
2024-09-19 14:42 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zuw4Y1VLDhjB7_hL@gallifrey \
--to=dave@treblig.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).