From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Andrew Melnychenko <andrew@daynix.com>
Subject: Re: [PATCH v2 0/7] Report fatal errors from failure with pre-opened eBPF RSS FDs
Date: Tue, 15 Oct 2024 14:50:20 +0100 [thread overview]
Message-ID: <Zw5zHHzsLknlxOXp@redhat.com> (raw)
In-Reply-To: <CACGkMEvxkVt7iFkTJT3u1fa9cAycoXyFq62Bq_f8Ebm6NLgpmQ@mail.gmail.com>
On Mon, Sep 09, 2024 at 10:34:32AM +0800, Jason Wang wrote:
> On Fri, Sep 6, 2024 at 5:57 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Thu, Sep 05, 2024 at 07:13:23PM +0100, Daniel P. Berrangé wrote:
> > > The virtio-net code for eBPF RSS is still ignoring errors when
> > > failing to load the eBPF RSS program passed in by the mgmt app
> > > via pre-opened FDs.
> > >
> > > This series re-factors the eBPF common code so that it actually
> > > reports using "Error" objects. Then it makes virtio-net treat
> > > a failure to load pre-opened FDs as a fatal problem. When doing
> > > speculative opening of eBPF FDs, QEMU merely prints a warning,
> > > and allows the software fallback to continue.
> > >
> > > Trace event coverage is significantly expanded to make this all
> > > much more debuggable too.
> >
> >
> > looks good
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > Jason's tree.
> >
>
> Queued.
I'm still not seeing this in master - is any PR planned in near future ?
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2024-10-15 13:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 18:13 [PATCH v2 0/7] Report fatal errors from failure with pre-opened eBPF RSS FDs Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 1/7] hw/net: fix typo s/epbf/ebpf/ in virtio-net Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 2/7] ebpf: drop redundant parameter checks in static methods Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 3/7] ebpf: improve error trace events Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 4/7] ebpf: add formal error reporting to all APIs Daniel P. Berrangé
2024-09-06 10:07 ` Philippe Mathieu-Daudé
2024-10-23 3:55 ` Jason Wang
2024-10-23 8:52 ` Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 5/7] hw/net: report errors from failing to use eBPF RSS FDs Daniel P. Berrangé
2024-09-06 10:09 ` Philippe Mathieu-Daudé
2024-09-05 18:13 ` [PATCH v2 6/7] ebpf: improve trace event coverage to all key operations Daniel P. Berrangé
2024-09-06 10:10 ` Philippe Mathieu-Daudé
2024-09-05 18:13 ` [PATCH v2 7/7] hw/net: improve tracing of eBPF RSS setup Daniel P. Berrangé
2024-09-06 10:12 ` Philippe Mathieu-Daudé
2024-09-06 9:57 ` [PATCH v2 0/7] Report fatal errors from failure with pre-opened eBPF RSS FDs Michael S. Tsirkin
2024-09-09 2:34 ` Jason Wang
2024-10-15 13:50 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw5zHHzsLknlxOXp@redhat.com \
--to=berrange@redhat.com \
--cc=andrew@daynix.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).