From: Zhao Liu <zhao1.liu@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Thomas Huth <thuth@redhat.com>, Anton Johansson <anjo@rev.ng>,
Yanan Wang <wangyanan55@huawei.com>,
Eduardo Habkost <eduardo@habkost.net>
Subject: Re: [PATCH 1/2] hw/core/machine: Add missing 'units.h' and 'error-report.h' headers
Date: Tue, 8 Oct 2024 11:55:22 +0800 [thread overview]
Message-ID: <ZwStKjT13QGFvfct@intel.com> (raw)
In-Reply-To: <20240930221900.59525-2-philmd@linaro.org>
On Tue, Oct 01, 2024 at 12:18:59AM +0200, Philippe Mathieu-Daudé wrote:
> Date: Tue, 1 Oct 2024 00:18:59 +0200
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 1/2] hw/core/machine: Add missing 'units.h' and
> 'error-report.h' headers
> X-Mailer: git-send-email 2.45.2
>
> Include the missing "qemu/units.h" to fix when refactoring code:
>
> ../hw/core/machine.c:743:34: error: use of undeclared identifier 'MiB'
> 743 | mc->default_ram_size = 128 * MiB;
> | ^
> ../hw/core/machine.c:750:44: error: use of undeclared identifier 'TiB'
> 750 | mc->smbios_memory_device_size = 2047 * TiB;
> | ^
>
> and "qemu/error-report.h" to fix:
>
> ../hw/core/machine.c:1029:13: error: call to undeclared function 'error_report' [-Wimplicit-function-declaration]
> 1029 | error_report("NUMA node %" PRIu16 " is missing, use "
> | ^
> ../hw/core/machine.c:1240:9: error: call to undeclared function 'warn_report' [-Wimplicit-function-declaration]
> 1240 | warn_report("CPU model %s is deprecated -- %s",
> | ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/core/machine.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2024-10-08 3:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 22:18 [PATCH 0/2] hw/core/machine: Extract compat properties to machine-compat.c Philippe Mathieu-Daudé
2024-09-30 22:18 ` [PATCH 1/2] hw/core/machine: Add missing 'units.h' and 'error-report.h' headers Philippe Mathieu-Daudé
2024-10-08 3:55 ` Zhao Liu [this message]
2024-09-30 22:19 ` [PATCH 2/2] hw/core/machine: Extract compat properties to machine-compat.c Philippe Mathieu-Daudé
2024-10-01 5:21 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwStKjT13QGFvfct@intel.com \
--to=zhao1.liu@intel.com \
--cc=anjo@rev.ng \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).