Re: [PATCH v5 04/16] crypto/hash-gnutls: Implement new hash API

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Oct 08, 2024 at 09:57:11AM +0200, Cédric Le Goater wrote:
> From: Alejandro Zeise <alejandro.zeise@seagate.com>
> 
> Implements the new hashing API in the gnutls hash driver.
> Supports creating/destroying a context, updating the context
> with input data and obtaining an output hash.
> 
> Signed-off-by: Alejandro Zeise <alejandro.zeise@seagate.com>
> [ clg: - Dropped qcrypto_hash_supports() in qcrypto_gnutls_hash_new()
>        - Reworked qcrypto_gnutls_hash_finalize()
>        - Handled gnutls_hash_init() errors in qcrypto_gnutls_hash_new()
>        - Replaced gnutls_hash_deinit() by gnutls_hash_output() in
>          qcrypto_gnutls_hash_finalize()
>        - Freed resources with gnutls_hash_deinit() in
>          qcrypto_gnutls_hash_free() ]
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>  crypto/hash-gnutls.c | 78 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|