From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, xieyongji@bytedance.com, kwolf@redhat.com,
hreitz@redhat.com, Coiby.Xu@gmail.com, pbonzini@redhat.com,
eduardo@habkost.net, mark.cave-ayland@ilande.co.uk,
michael.roth@amd.com, kkostiuk@redhat.com, qemu-block@nongnu.org
Subject: Re: [PATCH 3/7] block: Adjust check_block_size() signature
Date: Thu, 10 Oct 2024 16:06:06 +0100 [thread overview]
Message-ID: <ZwftXi-T0Zzm-NYK@redhat.com> (raw)
In-Reply-To: <20241010145630.985335-4-armbru@redhat.com>
On Thu, Oct 10, 2024 at 04:56:26PM +0200, Markus Armbruster wrote:
> Parameter @id is no longer used, drop. Return a bool to indicate
> success / failure, as recommended by qapi/error.h.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> util/block-helpers.h | 3 +--
> block/export/vduse-blk.c | 7 ++-----
> block/export/vhost-user-blk-server.c | 6 +-----
> hw/core/qdev-properties-system.c | 6 +-----
> util/block-helpers.c | 10 ++++++----
> 5 files changed, 11 insertions(+), 21 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-10-10 15:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 14:56 [PATCH 0/7] error: Eliminate QERR_PROPERTY_VALUE_OUT_OF_RANGE Markus Armbruster
2024-10-10 14:56 ` [PATCH 1/7] error: Drop superfluous #include "qapi/qmp/qerror.h" Markus Armbruster
2024-10-10 15:01 ` Daniel P. Berrangé
2024-10-10 14:56 ` [PATCH 2/7] block: Improve errors about block sizes Markus Armbruster
2024-10-10 15:05 ` Daniel P. Berrangé
2024-10-10 14:56 ` [PATCH 3/7] block: Adjust check_block_size() signature Markus Armbruster
2024-10-10 15:06 ` Daniel P. Berrangé [this message]
2024-10-10 14:56 ` [PATCH 4/7] target/i386/cpu: Avoid mixing signed and unsigned in property setters Markus Armbruster
2024-10-10 15:52 ` Daniel P. Berrangé
2024-10-10 14:56 ` [PATCH 5/7] target/i386/cpu: Improve errors for out of bounds property values Markus Armbruster
2024-10-10 15:56 ` Daniel P. Berrangé
2024-10-10 14:56 ` [PATCH 6/7] hw/intc/openpic: " Markus Armbruster
2024-10-10 15:56 ` Daniel P. Berrangé
2024-10-10 14:56 ` [PATCH 7/7] qerror: QERR_PROPERTY_VALUE_OUT_OF_RANGE is no longer used, drop Markus Armbruster
2024-10-10 15:57 ` Daniel P. Berrangé
2024-10-10 14:59 ` [PATCH 0/7] error: Eliminate QERR_PROPERTY_VALUE_OUT_OF_RANGE Markus Armbruster
2024-10-10 16:07 ` Daniel P. Berrangé
2024-10-10 17:03 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwftXi-T0Zzm-NYK@redhat.com \
--to=berrange@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=hreitz@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=kwolf@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).