From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01B74CFC52C for ; Mon, 14 Oct 2024 09:57:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0HpI-0000p1-8d; Mon, 14 Oct 2024 05:57:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0HpG-0000oS-5k for qemu-devel@nongnu.org; Mon, 14 Oct 2024 05:57:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0HpE-0000Wt-Ho for qemu-devel@nongnu.org; Mon, 14 Oct 2024 05:57:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728899835; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UrxdOf+Z4SWkeoGftAhO9bc8qwfSCMydo1Lx2/tKUa8=; b=PqlXvD7jkPuix+5K6zjoWsyhccybiff9YeXYGI1AZL5/dqtezZuWKhMm8+bwZyX414i6n/ dft8AEGvWWuyvcKdYuZR9A9+fbaKDa9ptQRwifagqHndRsqN9ANqO4ubkfsbtPXHJTqYGe 90peWFETJlFjFS2bb2czdVGtSGZESE8= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-A7EL2QrTMDGcek6ANLqHwQ-1; Mon, 14 Oct 2024 05:57:13 -0400 X-MC-Unique: A7EL2QrTMDGcek6ANLqHwQ-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 97A6B1956048; Mon, 14 Oct 2024 09:57:12 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.155]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 656743000198; Mon, 14 Oct 2024 09:57:10 +0000 (UTC) Date: Mon, 14 Oct 2024 10:57:05 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Dehan Meng Cc: qemu-devel@nongnu.org, kkostiuk@redhat.com, michael.roth@amd.com, peter.maydell@linaro.org Subject: Re: [PATCH v2 2/4] Proper initialization of n to 0 for getline to function correctly. Message-ID: References: <20241011031937.92216-1-demeng@redhat.com> <20241011031937.92216-3-demeng@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241011031937.92216-3-demeng@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.028, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Oct 11, 2024 at 11:19:35AM +0800, Dehan Meng wrote: > Signed-off-by: Dehan Meng > --- > qga/commands-linux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé > > diff --git a/qga/commands-linux.c b/qga/commands-linux.c > index 2c2b5f4ff2..b905f33a57 100644 > --- a/qga/commands-linux.c > +++ b/qga/commands-linux.c > @@ -2126,7 +2126,7 @@ GuestNetworkRouteList *qmp_guest_network_get_route(Error **errp) > GuestNetworkRouteList *head = NULL, **tail = &head; > const char *routeFiles[] = {"/proc/net/route", "/proc/net/ipv6_route"}; > FILE *fp; > - size_t n; > + size_t n = 0; > char *line = NULL; > int firstLine; > int is_ipv6; > -- > 2.40.1 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|