* [PATCH] meson.build: Remove ncurses workaround for OpenBSD
@ 2024-10-12 3:38 Brad Smith
2024-10-17 9:52 ` Daniel P. Berrangé
2024-10-18 16:25 ` Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Brad Smith @ 2024-10-12 3:38 UTC (permalink / raw)
To: Paolo Bonzini, Marc-Andr_ Lureau, Daniel P. Berrang_,
Philippe Mathieu-Daud_
Cc: qemu-devel
meson.build: Remove ncurses workaround for OpenBSD
OpenBSD 7.5 has upgraded to ncurses 6.4.
Signed-off-by: Brad Smith <brad@comstyle.com>
---
meson.build | 2 +-
ui/curses.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index 4ea1984fc5..22e7629d81 100644
--- a/meson.build
+++ b/meson.build
@@ -1374,7 +1374,7 @@ iconv = not_found
curses = not_found
if have_system and get_option('curses').allowed()
curses_test = '''
- #if defined(__APPLE__) || defined(__OpenBSD__)
+ #ifdef __APPLE__
#define _XOPEN_SOURCE_EXTENDED 1
#endif
#include <locale.h>
diff --git a/ui/curses.c b/ui/curses.c
index ec61615f7c..4d0be9b37d 100644
--- a/ui/curses.c
+++ b/ui/curses.c
@@ -38,7 +38,7 @@
#include "ui/input.h"
#include "sysemu/sysemu.h"
-#if defined(__APPLE__) || defined(__OpenBSD__)
+#ifdef __APPLE__
#define _XOPEN_SOURCE_EXTENDED 1
#endif
--
2.46.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] meson.build: Remove ncurses workaround for OpenBSD
2024-10-12 3:38 [PATCH] meson.build: Remove ncurses workaround for OpenBSD Brad Smith
@ 2024-10-17 9:52 ` Daniel P. Berrangé
2024-10-18 16:25 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2024-10-17 9:52 UTC (permalink / raw)
To: Brad Smith
Cc: Paolo Bonzini, Marc-Andr_ Lureau, Philippe Mathieu-Daud_,
qemu-devel, qemu-trivial
Cc'ing qemu-trivial
On Fri, Oct 11, 2024 at 11:38:55PM -0400, Brad Smith wrote:
> meson.build: Remove ncurses workaround for OpenBSD
>
> OpenBSD 7.5 has upgraded to ncurses 6.4.
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
> ---
> meson.build | 2 +-
> ui/curses.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> diff --git a/meson.build b/meson.build
> index 4ea1984fc5..22e7629d81 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1374,7 +1374,7 @@ iconv = not_found
> curses = not_found
> if have_system and get_option('curses').allowed()
> curses_test = '''
> - #if defined(__APPLE__) || defined(__OpenBSD__)
> + #ifdef __APPLE__
> #define _XOPEN_SOURCE_EXTENDED 1
> #endif
> #include <locale.h>
> diff --git a/ui/curses.c b/ui/curses.c
> index ec61615f7c..4d0be9b37d 100644
> --- a/ui/curses.c
> +++ b/ui/curses.c
> @@ -38,7 +38,7 @@
> #include "ui/input.h"
> #include "sysemu/sysemu.h"
>
> -#if defined(__APPLE__) || defined(__OpenBSD__)
> +#ifdef __APPLE__
> #define _XOPEN_SOURCE_EXTENDED 1
> #endif
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] meson.build: Remove ncurses workaround for OpenBSD
2024-10-12 3:38 [PATCH] meson.build: Remove ncurses workaround for OpenBSD Brad Smith
2024-10-17 9:52 ` Daniel P. Berrangé
@ 2024-10-18 16:25 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2024-10-18 16:25 UTC (permalink / raw)
To: Brad Smith, Paolo Bonzini, Marc-Andr_ Lureau, Daniel P. Berrang_,
Philippe Mathieu-Daud_
Cc: qemu-devel, QEMU Trivial
12.10.2024 06:38, Brad Smith wrote:
> meson.build: Remove ncurses workaround for OpenBSD
>
> OpenBSD 7.5 has upgraded to ncurses 6.4.
Queued to qemu-trivial tree, thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-18 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-12 3:38 [PATCH] meson.build: Remove ncurses workaround for OpenBSD Brad Smith
2024-10-17 9:52 ` Daniel P. Berrangé
2024-10-18 16:25 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).