Re: [PATCH v2 23/31] system: adapt to new import path for qobject data type headers

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Oct 18, 2024 at 06:06:18PM +0800, Zhao Liu wrote:
> Hi Daniel,
> 
> On Thu, Oct 17, 2024 at 12:33:35PM +0100, Daniel P. Berrangé wrote:
> > Date: Thu, 17 Oct 2024 12:33:35 +0100
> > From: "Daniel P. Berrangé" <berrange@redhat.com>
> > Subject: [PATCH v2 23/31] system: adapt to new import path for qobject data
> >  type headers
> > 
> > The qobject data type headers have moved from qapi/qmp/ to
> > qobject/.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  system/device_tree.c       | 2 +-
> >  system/dirtylimit.c        | 2 +-
> >  system/qdev-monitor.c      | 6 +++---
> >  system/rtc.c               | 1 +
> >  system/runstate-hmp-cmds.c | 2 +-
> >  system/vl.c                | 6 +++---
> >  6 files changed, 10 insertions(+), 9 deletions(-)
> > 
> > diff --git a/system/rtc.c b/system/rtc.c
> > index 216d2aee3a..e3bc2095f9 100644
> > --- a/system/rtc.c
> > +++ b/system/rtc.c
> > @@ -25,6 +25,7 @@
> >  #include "qemu/osdep.h"
> >  #include "qemu/cutils.h"
> >  #include "qapi/error.h"
> > +#include "qapi/qmp/qerror.h"
> 
> Is this a typo?

Yes, a rebase mistake. This was originally present, but since
removed.

> 
> >  #include "qemu/error-report.h"
> >  #include "qemu/option.h"
> >  #include "qemu/timer.h"
> 
> Regards,
> Zhao
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|