From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, manos.pitsidianakis@linaro.org,
pbonzini@redhat.com, qemu-trivial@nongnu.org
Subject: Re: [PATCH] configure: Replace literally printed '\n' with newline
Date: Fri, 18 Oct 2024 13:08:51 +0100 [thread overview]
Message-ID: <ZxJP0z9NWf0DpGrK@redhat.com> (raw)
In-Reply-To: <20241018120557.43586-1-kwolf@redhat.com>
On Fri, Oct 18, 2024 at 02:05:57PM +0200, Kevin Wolf wrote:
> The idea here was to leave an empty line before the message, but by
> default, echo prints '\n' literally instead of interpreting it. Use a
> separate echo without parameter instead like in other places in the
> script.
>
> Fixes: 6fdc5bc173188f5e4942616b16d589500b874a15
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> configure | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-10-18 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 12:05 [PATCH] configure: Replace literally printed '\n' with newline Kevin Wolf
2024-10-18 12:08 ` Daniel P. Berrangé [this message]
2024-10-21 12:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxJP0z9NWf0DpGrK@redhat.com \
--to=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).