From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 769B1D30013 for ; Fri, 18 Oct 2024 14:34:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1o3J-0004pP-NR; Fri, 18 Oct 2024 10:34:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1o3H-0004nD-Dw for qemu-devel@nongnu.org; Fri, 18 Oct 2024 10:34:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1o3F-0001Om-Ov for qemu-devel@nongnu.org; Fri, 18 Oct 2024 10:34:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729262040; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RjvIqZ6sKBhQv3LbVLt6RS4d/gTp2SK33ycJ3U3MBpA=; b=DwUQWhVF5AZ45RGAFJT/S5Viwak8DhcJrOgKP6bho43AkoJLRiPlnwftFmvKHXfpp4wPX2 tn55ZkvjrCrZR5jiQgo3Ea0HbibM1/4aMmh3f9AS7vmaj5Wj3gnWRpo9cHjUQVkQDRDcPU 4eiY7a8POl8zOQL2Ka+Yy12r79VAWj8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-MTUWukLoP7yTEm1UPncTsw-1; Fri, 18 Oct 2024 10:33:57 -0400 X-MC-Unique: MTUWukLoP7yTEm1UPncTsw-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D60719560B6; Fri, 18 Oct 2024 14:33:56 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.61]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EEE3A300018D; Fri, 18 Oct 2024 14:33:52 +0000 (UTC) Date: Fri, 18 Oct 2024 15:33:49 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Fabiano Rosas Cc: Peter Maydell , qemu-devel@nongnu.org, Peter Xu , Alex =?utf-8?Q?Benn=C3=A9e?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta Subject: Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job Message-ID: References: <20241017143211.17771-1-farosas@suse.de> <20241017143211.17771-5-farosas@suse.de> <87r08e3d74.fsf@suse.de> <87zfn11pvc.fsf@suse.de> <87ttd91o4a.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ttd91o4a.fsf@suse.de> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.016, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Oct 18, 2024 at 11:28:53AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Oct 18, 2024 at 10:51:03AM -0300, Fabiano Rosas wrote: > >> Daniel P. Berrangé writes: > >> > >> > That could be a good reason to split the migration-test into > >> > two distinct programs. One program that runs for every target, > >> > and one that is only run once, for some arbitrary "primary" > >> > target ? > >> > >> What do you mean by distinct programs? It's not the migration-test that > >> decides on which targets it runs, it's meson.build. We register a test() > >> for each target, same as with any other qtest. Maybe I misunderstood > >> you... > > > > If we split, we could have meson.build register "migration-smoketest" > > for every target while registering "migration-bigtest" for just 1 target. > > Isn't that a bunch of shuffling code around just to have two different > invocations of migration-test? Yes, pretty much, but that's not an inherantly bad thing. Migration is a bit of an outlier in its attempt to test the entire subsystem from a single test binary. > There's the possibility of using the gtester path like > /x86_64/migration/smoke and passing '-r' when invoking via meson. That > requires way fewer changes in the C code. It moves the complexity into > meson.build, which might be worse. > > Alex's idea of full set for KVM arch + a TCG arch would probably be > trickier in meson. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|