[PATCH] stubs: remove stubs/qdev.c

[PATCH] stubs: remove stubs/qdev.c

[Paolo Bonzini]

qapi_event_send_device_deleted is always included (together
with the rest of QAPI) in libqemuutil.a, so it is unnecessary
to include a stub for it.

This avoids a duplicate symbol in libqemuutil.a, which in
principle could result in missing events on the monitor.

Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 stubs/qdev.c      | 22 ----------------------
 stubs/meson.build |  1 -
 2 files changed, 23 deletions(-)
 delete mode 100644 stubs/qdev.c

diff --git a/stubs/qdev.c b/stubs/qdev.c
deleted file mode 100644
index 7e957b3e524..00000000000
--- a/stubs/qdev.c
+++ /dev/null
@@ -1,22 +0,0 @@
-/*
- * QOM stubs
- *
- * Copyright (c) 2021 Red Hat, Inc.
- *
- * Author:
- *   Philippe Mathieu-Daudé <philmd@redhat.com>
- *
- * SPDX-License-Identifier: GPL-2.0-or-later
- *
- * This work is licensed under the terms of the GNU GPL, version 2 or later.
- * See the COPYING file in the top-level directory.
- */
-
-#include "qemu/osdep.h"
-#include "qapi/qapi-events-qdev.h"
-
-void qapi_event_send_device_deleted(const char *device,
-                                    const char *path)
-{
-    /* Nothing to do. */
-}
diff --git a/stubs/meson.build b/stubs/meson.build
index 772a3e817df..64b7263dde2 100644
--- a/stubs/meson.build
+++ b/stubs/meson.build
@@ -55,7 +55,6 @@ endif
 if have_user
   # Symbols that are used by hw/core.
   stub_ss.add(files('cpu-synchronize-state.c'))
-  stub_ss.add(files('qdev.c'))
 endif
 
 if have_system
-- 
2.46.2

Re: [PATCH] stubs: remove stubs/qdev.c

[Zhao Liu]

On Fri, Oct 18, 2024 at 04:33:33PM +0200, Paolo Bonzini wrote:
> Date: Fri, 18 Oct 2024 16:33:33 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH] stubs: remove stubs/qdev.c
> X-Mailer: git-send-email 2.46.2
> 
> qapi_event_send_device_deleted is always included (together
> with the rest of QAPI) in libqemuutil.a, so it is unnecessary
> to include a stub for it.
> 
> This avoids a duplicate symbol in libqemuutil.a, which in
> principle could result in missing events on the monitor.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  stubs/qdev.c      | 22 ----------------------
>  stubs/meson.build |  1 -
>  2 files changed, 23 deletions(-)
>  delete mode 100644 stubs/qdev.c

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>