From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2013CD0E6D9 for ; Mon, 21 Oct 2024 09:48:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2p1E-00009e-HR; Mon, 21 Oct 2024 05:48:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2p15-000091-PK for qemu-devel@nongnu.org; Mon, 21 Oct 2024 05:48:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2p14-0004Tg-2i for qemu-devel@nongnu.org; Mon, 21 Oct 2024 05:47:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729504077; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XV5lWyMc696jfF8fpjQ/ePQGJbmEV+PHJMd2WAZYGxg=; b=N6KXFH1Rd3D1dkg6O70vG0RHZD/REj6cSa17+cmnzctACEOIayNHgPVJgsIFZgjBxsNdy/ T3qdM3mX/5KEfGCg8//M9CEM95napHjVDM9z8/Azfp4i0c1yDseszK7CxsGsf0ek4vPQzN O9z2PLypQOwVm1za4mf3nTqnr4DVS2A= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-324-gtjl8h9-PkiNCvMv7SqlTg-1; Mon, 21 Oct 2024 05:47:53 -0400 X-MC-Unique: gtjl8h9-PkiNCvMv7SqlTg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0A63419560B1; Mon, 21 Oct 2024 09:47:46 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.27]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C1BB1956089; Mon, 21 Oct 2024 09:47:38 +0000 (UTC) Date: Mon, 21 Oct 2024 10:47:35 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?C=C3=A9dric?= Le Goater Cc: Thomas Huth , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v3] tests/functional: Convert most Aspeed machine tests Message-ID: References: <20241018071726.2723934-1-clg@redhat.com> <341dff70-d0bc-432b-8764-8cb9b1aba1eb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <341dff70-d0bc-432b-8764-8cb9b1aba1eb@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.527, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Oct 21, 2024 at 11:31:03AM +0200, Cédric Le Goater wrote: > Hello Thomas, > > > On 10/21/24 10:53, Thomas Huth wrote: > > On 18/10/2024 09.17, Cédric Le Goater wrote: > > > This is a simple conversion of the tests with some cleanups and > > > adjustments to match the new test framework. Replace the zephyr image > > > MD5 hashes with SHA256 hashes while at it. > > > > > > The SDK tests depend on a ssh class from avocado.utils which is > > > difficult to replace. To be addressed separately. > > > > > > Signed-off-by: Cédric Le Goater > > > --- > > > >  Hi Cédric, > > > > I'm seeing errors when I try to run "make check-functional" with this patch multiple times, e.g.: > > > >   File "/home/thuth/devel/qemu/tests/functional/test_arm_aspeed.py", line 111, in test_arm_ast2400_palmetto_openbmc_v2_9_0 > >     image_path = self.ASSET_PALMETTO_FLASH.fetch() > >                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >   File "/home/thuth/devel/qemu/tests/functional/qemu_test/asset.py", line 104, in fetch > >     raise Exception("Asset cache is invalid and downloads disabled") > > Exception: Asset cache is invalid and downloads disabled > > > > Could it be that the tests alter the file in the download cache? > > yes. the flash image is updated by Linux. I don't reproduce the issue > on my build though. Are you using special options ? NB, this would only happen if invoked via 'make check-functional' as that has the logic to run asset downloads seprately from the tests. If you were just directly invoking the test program you wouldn't see this error message, as it'll just re-download. You would have to run the test twice too I guess, first time downloads and modifies the image, second time sees the modified image and complains. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|