From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Hyman Huang <yong.huang@smartx.com>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Fabiano Rosas <farosas@suse.de>
Subject: Re: [PATCH v2 3/5] guestperf: Support deferred migration for multifd
Date: Mon, 21 Oct 2024 17:35:44 +0100 [thread overview]
Message-ID: <ZxaC4OjPA28nPNo_@redhat.com> (raw)
In-Reply-To: <b8dfc975dcb9f48faf5cef154aaafd248179f664.1729275266.git.yong.huang@smartx.com>
On Sat, Oct 19, 2024 at 02:25:05AM +0800, Hyman Huang wrote:
> The way to enable multifd migration has been changed by commit,
> 82137e6c8c (migration: enforce multifd and postcopy preempt to
> be set before incoming), and guestperf has not made the
> necessary changes. If multifd migration had been enabled in the
> previous manner, the following error would have occurred:
> Multifd must be set before incoming starts
>
> Supporting deferred migration will fix it.
>
> Signed-off-by: Hyman Huang <yong.huang@smartx.com>
> ---
> scripts/migration/guestperf/engine.py | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-10-21 16:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 18:25 [PATCH v2 0/5] Guestperf: miscellaneous refinement and enrichment Hyman Huang
2024-10-18 18:25 ` [PATCH v2 1/5] tests/migration: Move the guestperf tool to scripts directory Hyman Huang
2024-10-21 16:33 ` Daniel P. Berrangé
2024-10-18 18:25 ` [PATCH v2 2/5] tests/migration: Make initrd-stress.img built by default Hyman Huang
2024-10-21 16:33 ` Daniel P. Berrangé
2024-10-18 18:25 ` [PATCH v2 3/5] guestperf: Support deferred migration for multifd Hyman Huang
2024-10-21 16:35 ` Daniel P. Berrangé [this message]
2024-10-18 18:25 ` [PATCH v2 4/5] guestperf: Nitpick the inconsistent parameters Hyman Huang
2024-10-21 16:36 ` Daniel P. Berrangé
2024-10-18 18:25 ` [PATCH v2 5/5] guestperf: Introduce multifd compression option Hyman Huang
2024-10-21 16:37 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxaC4OjPA28nPNo_@redhat.com \
--to=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yong.huang@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).