From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Dehan Meng <demeng@redhat.com>
Cc: qemu-devel@nongnu.org, kkostiuk@redhat.com, michael.roth@amd.com,
peter.maydell@linaro.org
Subject: Re: [PATCH v3 2/4] qemu-ga: Initialize correctly so getline works properly
Date: Mon, 21 Oct 2024 17:47:09 +0100 [thread overview]
Message-ID: <ZxaFjYWZ_QjC1JAm@redhat.com> (raw)
In-Reply-To: <20241021132839.463255-8-demeng@redhat.com>
On Mon, Oct 21, 2024 at 09:28:37PM +0800, Dehan Meng wrote:
> Proper initialization of param 'size_t n' to '0' for
> getline to function correctly.
>
> Signed-off-by: Dehan Meng <demeng@redhat.com>
> ---
> qga/commands-linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-10-21 16:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 13:28 [PATCH v2 0/4] qemu-ga: Fix some potential issues find by coverity Dehan Meng
2024-10-21 13:28 ` [PATCH v2 1/4] sscanf return values are checked to ensure correct parsing Dehan Meng
2024-10-21 13:28 ` [PATCH v2 2/4] Proper initialization of n to 0 for getline to function correctly Dehan Meng
2024-10-21 13:28 ` [PATCH v2 3/4] Avoiding freeing line prematurely. It's now only freed at the end of the function Dehan Meng
2024-10-21 13:28 ` [PATCH v2 4/4] For correcting code style: Variable declarations moved to the beginning of blocks Followed the coding style of using snake_case for variable names. And merged redundant route and networkroute variables Dehan Meng
2024-10-21 13:28 ` [PATCH v3 0/4] qemu-ga: Modify commits message and make some minor code update Dehan Meng
2024-10-21 13:28 ` [PATCH v3 1/4] qemu-ga: 'Null' check for mandatory parameters Dehan Meng
2024-10-21 16:45 ` Daniel P. Berrangé
2024-10-21 17:13 ` Konstantin Kostiuk
2024-10-22 10:37 ` Dehan Meng
2024-10-21 13:28 ` [PATCH v3 2/4] qemu-ga: Initialize correctly so getline works properly Dehan Meng
2024-10-21 16:47 ` Daniel P. Berrangé [this message]
2024-10-21 13:28 ` [PATCH v3 3/4] qemu-ga: Avoiding freeing line prematurely Dehan Meng
2024-10-21 16:47 ` Daniel P. Berrangé
2024-10-21 13:28 ` [PATCH v3 4/4] qemu-ga: For correcting code style Dehan Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxaFjYWZ_QjC1JAm@redhat.com \
--to=berrange@redhat.com \
--cc=demeng@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).