From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Jiqian Chen <Jiqian.Chen@amd.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Anthony PERARD <anthony@xenproject.org>,
Paul Durrant <paul@xen.org>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
qemu-devel@nongnu.org, xen-devel@lists.xenproject.org,
Huang Rui <Ray.Huang@amd.com>
Subject: Re: [QEMU PATCH v8] xen/passthrough: use gsi to map pirq when dom0 is PVH
Date: Wed, 23 Oct 2024 01:07:58 +0200 [thread overview]
Message-ID: <ZxgwUd3riLmFzFC4@mail-itl> (raw)
In-Reply-To: <20241016062827.2301004-1-Jiqian.Chen@amd.com>
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
On Wed, Oct 16, 2024 at 02:28:27PM +0800, Jiqian Chen wrote:
> --- a/hw/xen/xen_pt.h
> +++ b/hw/xen/xen_pt.h
> @@ -36,6 +36,7 @@ void xen_pt_log(const PCIDevice *d, const char *f, ...) G_GNUC_PRINTF(2, 3);
> # define XEN_PT_LOG_CONFIG(d, addr, val, len)
> #endif
>
> +#define DOMID_RUN_QEMU 0
Please, don't hardcode dom0 here, QEMU can be running in a stubdomain
too (in which case, this will hilariously explode, as it will check what
dom0 is, instead of where QEMU is running).
Stewart already provided an alternative.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-10-22 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 6:28 [QEMU PATCH v8] xen/passthrough: use gsi to map pirq when dom0 is PVH Jiqian Chen
2024-10-21 20:55 ` Stewart Hildebrand
2024-10-23 9:29 ` Chen, Jiqian
2024-10-22 23:07 ` Marek Marczykowski-Górecki [this message]
2024-10-23 9:30 ` Chen, Jiqian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxgwUd3riLmFzFC4@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=Jiqian.Chen@amd.com \
--cc=Ray.Huang@amd.com \
--cc=anthony@xenproject.org \
--cc=edgar.iglesias@gmail.com \
--cc=paul@xen.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).