From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: qemu-devel@nongnu.org,
Yuri Benditovich <yuri.benditovich@daynix.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Andrew Melnychenko <andrew@daynix.com>
Subject: Re: [PATCH v2 4/7] ebpf: add formal error reporting to all APIs
Date: Wed, 23 Oct 2024 09:52:13 +0100 [thread overview]
Message-ID: <Zxi5PeTIKh7RAh8v@redhat.com> (raw)
In-Reply-To: <CACGkMEv5DJ=6eH65UE9qjbUt9KWrMnqg1TJKU-d1SBodhLsbRg@mail.gmail.com>
On Wed, Oct 23, 2024 at 11:55:42AM +0800, Jason Wang wrote:
> On Fri, Sep 6, 2024 at 2:13 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > The eBPF code is currently reporting error messages through trace
> > events. Trace events are fine for debugging, but they are not to be
> > considered the primary error reporting mechanism, as their output
> > is inaccessible to callers.
> >
> > This adds an "Error **errp" parameter to all methods which have
> > important error scenarios to report to the caller.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>
> This doesn't compile:
>
> [3/84] Compiling C object libcommon.a.p/ebpf_ebpf_rss-stub.c.o
Opps, I didn't update the stub for the new Error parameter.
I've sent a new series with the fix
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-10-23 8:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 18:13 [PATCH v2 0/7] Report fatal errors from failure with pre-opened eBPF RSS FDs Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 1/7] hw/net: fix typo s/epbf/ebpf/ in virtio-net Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 2/7] ebpf: drop redundant parameter checks in static methods Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 3/7] ebpf: improve error trace events Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 4/7] ebpf: add formal error reporting to all APIs Daniel P. Berrangé
2024-09-06 10:07 ` Philippe Mathieu-Daudé
2024-10-23 3:55 ` Jason Wang
2024-10-23 8:52 ` Daniel P. Berrangé [this message]
2024-09-05 18:13 ` [PATCH v2 5/7] hw/net: report errors from failing to use eBPF RSS FDs Daniel P. Berrangé
2024-09-06 10:09 ` Philippe Mathieu-Daudé
2024-09-05 18:13 ` [PATCH v2 6/7] ebpf: improve trace event coverage to all key operations Daniel P. Berrangé
2024-09-06 10:10 ` Philippe Mathieu-Daudé
2024-09-05 18:13 ` [PATCH v2 7/7] hw/net: improve tracing of eBPF RSS setup Daniel P. Berrangé
2024-09-06 10:12 ` Philippe Mathieu-Daudé
2024-09-06 9:57 ` [PATCH v2 0/7] Report fatal errors from failure with pre-opened eBPF RSS FDs Michael S. Tsirkin
2024-09-09 2:34 ` Jason Wang
2024-10-15 13:50 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxi5PeTIKh7RAh8v@redhat.com \
--to=berrange@redhat.com \
--cc=andrew@daynix.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).