From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04736D0BB72 for ; Thu, 24 Oct 2024 08:47:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3tUN-00015S-00; Thu, 24 Oct 2024 04:46:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3tUL-000154-KX for qemu-devel@nongnu.org; Thu, 24 Oct 2024 04:46:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3tUJ-0003CP-3n for qemu-devel@nongnu.org; Thu, 24 Oct 2024 04:46:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729759592; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9DPzN3A2ihFKQ97Su/sg757xcRqdmx6CcF9313uYWlY=; b=XaKSCeL5BqjqNrDxAM0Qc0rLqBkkqCMug6XkqUgIlYAX3neD3rrI4EdXliyu3PSw3WPvB9 EUI66RjljUz2fa64hP52fFiJVHe4X+HwX74nr02GQKLmv/3z5L4Lcb025OD1ASaRwkYCpb 9ZiNfb3Gy/8AZzSGxa5PKU6OpnsEC84= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-kNJdsOROM-KjAzPXLFit5g-1; Thu, 24 Oct 2024 04:46:29 -0400 X-MC-Unique: kNJdsOROM-KjAzPXLFit5g-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C75201955D4D; Thu, 24 Oct 2024 08:46:26 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.57]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1E2C9196BB7D; Thu, 24 Oct 2024 08:46:23 +0000 (UTC) Date: Thu, 24 Oct 2024 09:46:20 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Rob Landley , Yoshinori Sato , Magnus Damm Subject: Re: [PATCH 1/2] Revert "Remove the unused sh4eb target" Message-ID: References: <20241024082735.42324-1-thuth@redhat.com> <20241024082735.42324-2-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241024082735.42324-2-thuth@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.263, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Oct 24, 2024 at 10:27:34AM +0200, Thomas Huth wrote: > This reverts commit 73ceb12960e686b763415f0880cc5171ccce01cf. > > The "r2d" machine can work in big endian mode, see: > > https://lore.kernel.org/qemu-devel/d6755445-1060-48a8-82b6-2f392c21f9b9@landley.net/ > > So the reasoning for removing sh4eb was wrong. This is a good example of why bypassing the deprecation process is generally a bad idea. Even if we believe something is unusable, we may not be aware of the full situation. The deprecation period gives us an opportunity to solicit more diverse information with which we can make the final deletion decision. > > Signed-off-by: Thomas Huth > --- > configs/devices/sh4eb-softmmu/default.mak | 3 +++ > configs/targets/sh4eb-softmmu.mak | 2 ++ > qapi/machine.json | 2 +- > tests/qtest/endianness-test.c | 1 + > tests/qtest/machine-none-test.c | 1 + > .gitlab-ci.d/buildtest.yml | 2 +- > .gitlab-ci.d/cirrus.yml | 2 +- > .gitlab-ci.d/crossbuilds.yml | 2 +- > .travis.yml | 2 +- > tests/qemu-iotests/testenv.py | 1 + > tests/qtest/meson.build | 1 + > 11 files changed, 14 insertions(+), 5 deletions(-) > create mode 100644 configs/devices/sh4eb-softmmu/default.mak > create mode 100644 configs/targets/sh4eb-softmmu.mak Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|