From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C41B1D1039A for ; Fri, 25 Oct 2024 15:51:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t4Mae-0004JP-Kb; Fri, 25 Oct 2024 11:51:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4MaZ-0004Hx-2D for qemu-devel@nongnu.org; Fri, 25 Oct 2024 11:51:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4MaX-0003Q1-Fa for qemu-devel@nongnu.org; Fri, 25 Oct 2024 11:50:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729871454; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6FvhmmA6psm5Cd4vegaSeof9B4Z+518jhtoT5JJvhB4=; b=Abni3FZxFqQ4RGcH6w71EJka/rUo/2w6FIt1AeojSBqAB5lJPFmFTlDkYT+CgXJ8sEfJ5S KDJ8gLrzfyOuWTBw7jPmPR6NRq2kLbcj734mts0851uvzfXSf4oi7FXkKxfr4mOB51KT4c NxDLo8I395ug3uXELpvuD5d4vtOerro= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-iS8kAUS7PkaGErimOnLTDQ-1; Fri, 25 Oct 2024 11:50:48 -0400 X-MC-Unique: iS8kAUS7PkaGErimOnLTDQ-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 992A819560B0; Fri, 25 Oct 2024 15:50:47 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.164]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 23E15300018D; Fri, 25 Oct 2024 15:50:45 +0000 (UTC) Date: Fri, 25 Oct 2024 16:50:42 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Thomas Huth , QEMU Developers , Peter Maydell Subject: Re: 'make check-functional' uses lots of disk space in build tree Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.454, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Oct 25, 2024 at 12:29:13PM -0300, Philippe Mathieu-Daudé wrote: > On 25/10/24 10:57, Daniel P. Berrangé wrote: > > On Fri, Oct 25, 2024 at 02:50:50PM +0100, Peter Maydell wrote: > > > I notice that with the recent migration to check-functional we > > > seem to be using a lot of disk space in the build tree: for > > > one of my build trees > > > du -h build/arm-clang/tests/functional/ > > > returns a total of 4.5GB used, for instance, most of which seems > > > to be guest binary files. > > > > > > Shouldn't something be cleaning these up after a test run? > > > > The big problem seems to be tests/functional/test_aarch64_sbsaref.py > > which is creating a pair of 256 MB firmware files on every test > > and not deleting them. > > > > The tests/functional/test_arm_raspi2.py is also uncompressing some > > archives and not deleting them. > > Some files could be added back to the cache (with the proper hash) > so we don't need to re-extract or re-create them everytime. Unless we've seen a significant time penalty from the extraction, I think we shouldn't complicate our cache handling. Simplicity is of great value when it comes to debugging problems with tests. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|