From: Tao Su <tao1.su@linux.intel.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Zhao Liu <zhao1.liu@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 4/8] target/i386: add AVX10 feature and AVX10 version property
Date: Thu, 31 Oct 2024 14:07:16 +0800 [thread overview]
Message-ID: <ZyMeiXbey7FlEhad@linux.bj.intel.com> (raw)
In-Reply-To: <92635403-e483-45a8-afcd-0e8fa5080f23@intel.com>
On Thu, Oct 31, 2024 at 01:52:24PM +0800, Xiaoyao Li wrote:
[ ... ]
> > I mainly want to let avx10_version be assigned only when -cpu host or max,
> > so that it can be distinguished from the cpu model. This should also be
> > Paolo's original intention in v2.
>
> avx10_version needs to be assigned with a default valid value, when user
> enables avx10 explicitly without specifying avx10_version. It also applies
> to (existing) named cpu models other than GraniteRapids-v2 (which is added
> by this series). E.g.,
>
> -cpu GraniteRapids-v1,+avx10
>
> So if you are going to make default value as -1, then you need to add
> something in x86_cpu_load_model()
>
> if (!def->avx10_version) {
> def->avx10_version = -1;
> }
Good suggestion, thanks for the reminder!
next prev parent reply other threads:[~2024-10-31 6:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 15:18 [PATCH v2 0/8] Add AVX10.1 CPUID support and GraniteRapids-v2 model Paolo Bonzini
2024-10-29 15:18 ` [PATCH 1/8] target/i386: cpu: set correct supported XCR0 features for TCG Paolo Bonzini
2024-10-30 2:56 ` Zhao Liu
2024-10-29 15:18 ` [PATCH 2/8] target/i386: do not rely on ExtSaveArea for accelerator-supported XCR0 bits Paolo Bonzini
2024-10-30 3:50 ` Zhao Liu
2024-10-29 15:18 ` [PATCH 3/8] target/i386: return bool from x86_cpu_filter_features Paolo Bonzini
2024-10-30 5:19 ` Zhao Liu
2024-10-29 15:18 ` [PATCH 4/8] target/i386: add AVX10 feature and AVX10 version property Paolo Bonzini
2024-10-30 3:05 ` Tao Su
2024-10-30 8:09 ` Zhao Liu
2024-10-30 8:44 ` Zhao Liu
2024-10-30 9:37 ` Tao Su
2024-10-30 13:21 ` Zhao Liu
2024-10-30 14:05 ` Tao Su
2024-10-30 15:55 ` Zhao Liu
2024-10-31 4:39 ` Tao Su
2024-10-31 5:52 ` Xiaoyao Li
2024-10-31 6:07 ` Tao Su [this message]
2024-10-31 7:12 ` Zhao Liu
2024-10-31 7:18 ` Zhao Liu
2024-10-31 7:19 ` Tao Su
2024-10-29 15:18 ` [PATCH 5/8] target/i386: add CPUID.24 features for AVX10 Paolo Bonzini
2024-10-30 8:50 ` Zhao Liu
2024-10-29 15:18 ` [PATCH 6/8] target/i386: Add feature dependencies " Paolo Bonzini
2024-10-29 15:18 ` [PATCH 7/8] target/i386: Add AVX512 state when AVX10 is supported Paolo Bonzini
2024-10-29 20:11 ` Paolo Bonzini
2024-10-30 8:54 ` Zhao Liu
2024-10-29 15:18 ` [PATCH 8/8] target/i386: Introduce GraniteRapids-v2 model Paolo Bonzini
2024-10-30 3:18 ` [PATCH v2 0/8] Add AVX10.1 CPUID support and " Tao Su
2024-10-30 8:35 ` Paolo Bonzini
2024-10-30 8:52 ` Tao Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyMeiXbey7FlEhad@linux.bj.intel.com \
--to=tao1.su@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoyao.li@intel.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).