Re: [PULL 00/18] Migration 20241030 patches

[Peter Xu <peterx@redhat.com>]

On Thu, Oct 31, 2024 at 02:52:28PM +0000, Peter Maydell wrote:
> On Thu, 31 Oct 2024 at 14:50, Peter Xu <peterx@redhat.com> wrote:
> >
> > On Thu, Oct 31, 2024 at 01:28:31PM +0000, Peter Maydell wrote:
> > > Hi; this fails to build on macos:
> > >
> > > https://gitlab.com/qemu-project/qemu/-/jobs/8237753019
> > >
> > > ../ui/cocoa.m:40:10: fatal error: 'sysemu/cpu-throttle.h' file not found
> > >     40 | #include "sysemu/cpu-throttle.h"
> > >        |          ^~~~~~~~~~~~~~~~~~~~~~~
> > > 1 error generated.
> >
> > Errr, cocoa.m used cpu-throttle for Speed feature.. so it needs it to be
> > exported.
> >
> > Luckily cocoa.m is only compiled in system_ss.  The simplest fix so far is
> > to only move cpu-throttle.c, not cpu-throttle.h yet in the commit:
> >
> > "migration: Move cpu-throttole.c from system to migration"
> >
> > Fixup patch to be squashed:
> >
> > ===8<===
> > From 68515db81e28832cbd24b1cdbc12aeb618c9de54 Mon Sep 17 00:00:00 2001
> > From: Peter Xu <peterx@redhat.com>
> > Date: Thu, 31 Oct 2024 10:37:29 -0400
> > Subject: [PATCH] fixup! migration: Move cpu-throttole.c from system to
> >  migration
> 
> If you're fixing up that commit anyway you could also fix
> the typo in the commit message: s/throttole/throttle/.

Will do.

-- 
Peter Xu