From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FCBDE6B243 for ; Fri, 1 Nov 2024 11:33:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6ptz-0000Ak-54; Fri, 01 Nov 2024 07:33:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6ptl-0008US-PP for qemu-devel@nongnu.org; Fri, 01 Nov 2024 07:33:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6ptk-00074Y-1u for qemu-devel@nongnu.org; Fri, 01 Nov 2024 07:33:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730460779; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7kr2R9Vf+l7UX4sDPCf9aX5mpyxlghu2Tf41u6KIZA0=; b=DPFthRM81M5m0O85Q8b5zQzIspKHD5eOHuTROssPf4c9HSEHqDp9OOnKwMoRd7zjiBMlmu pzuktZwSkl0GtlV6r9S9eHVHR9BONSVxw+1a70DmOBR63T3MyJ5nmNo4jtImt3sQi7kf+3 ozXX3lf/4Gr1nCbPbVCm9sQuHqeoQCw= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-myfsvJKvNyWJcybE7p1e9A-1; Fri, 01 Nov 2024 07:32:57 -0400 X-MC-Unique: myfsvJKvNyWJcybE7p1e9A-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 54E881955F41 for ; Fri, 1 Nov 2024 11:32:56 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.145]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E244619560A2; Fri, 1 Nov 2024 11:32:54 +0000 (UTC) Date: Fri, 1 Nov 2024 11:32:51 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Xu Cc: qemu-devel@nongnu.org, Paolo Bonzini Subject: Re: [RFC 4/5] qom: introduce object_new_dynamic() Message-ID: References: <20241031155350.3240361-1-berrange@redhat.com> <20241031155350.3240361-5-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Oct 31, 2024 at 03:22:07PM -0400, Peter Xu wrote: > On Thu, Oct 31, 2024 at 03:53:49PM +0000, Daniel P. Berrangé wrote: > > object_new() has a failure scenario where it will assert() if given > > an abstract type. Callers which are creating objects based on user > > input, or unknown/untrusted type names, must manually check the > > result of object_class_is_abstract() before calling object_new() > > to propagate an Error, instead of asserting. > > > > Introduce a object_new_dynamic() method which is a counterpart to > > object_new() that directly returns an Error, instead of asserting. > > This new method is to be used where the typename is specified > > dynamically by code separate from the immediate caller. > > > > Signed-off-by: Daniel P. Berrangé > > Needs some patch order changes.. v.s. the previous one. Opps, yes, of course. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|