[QUESTION/ISSUE] edk2 missing dependency

[QUESTION/ISSUE] edk2 missing dependency

[CLEMENT MATHIEU--DRIF]

Hi everyone,

It seems that https://github.com/Zeex/subhook (EDK2 submodule) is not 
longer available on github (which makes recursive pull of submodules 
fail for a lot of people).
Do you think we should do something on our side?

Thanks
 >cmd

Re: [QUESTION/ISSUE] edk2 missing dependency

[Daniel P. Berrangé]

On Mon, Nov 04, 2024 at 02:32:53PM +0000, CLEMENT MATHIEU--DRIF wrote:
> Hi everyone,
> 
> It seems that https://github.com/Zeex/subhook (EDK2 submodule) is not 
> longer available on github (which makes recursive pull of submodules 
> fail for a lot of people).
> Do you think we should do something on our side?

Once EDK2 fix the problem, then QEMU can update its EDK2 submodule to
get the fix.

It should not be a major problem meanwhile because there's no compelling
reason for QEMU contributors to do a recursive checkout of all submodules.
It'll only affect those with EDK2 checked out, which is not a common thing
to need to do to start with, since we provide rebuilt EDK2.

Our make-release script checks out EDK2 submodule, but does not do this
recursively - it only pulls  a couple of hand-picked sub-submodules, not
including Zeex/subhook.

If you know of any other scenarios that are a problem please say.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [QUESTION/ISSUE] edk2 missing dependency

[Peter Maydell]

On Mon, 4 Nov 2024 at 14:43, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Mon, Nov 04, 2024 at 02:32:53PM +0000, CLEMENT MATHIEU--DRIF wrote:
> > Hi everyone,
> >
> > It seems that https://github.com/Zeex/subhook (EDK2 submodule) is not
> > longer available on github (which makes recursive pull of submodules
> > fail for a lot of people).
> > Do you think we should do something on our side?
>
> Once EDK2 fix the problem, then QEMU can update its EDK2 submodule to
> get the fix.

Looks like the "EDK2 fix the problem" part has now happened:

https://github.com/tianocore/edk2/commit/95d8a1c255cfb8e063d679930d08ca6426eb5701

thanks
-- PMM

Re: [QUESTION/ISSUE] edk2 missing dependency

[Peter Maydell]

On Tue, 5 Nov 2024 at 16:48, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 4 Nov 2024 at 14:43, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Mon, Nov 04, 2024 at 02:32:53PM +0000, CLEMENT MATHIEU--DRIF wrote:
> > > Hi everyone,
> > >
> > > It seems that https://github.com/Zeex/subhook (EDK2 submodule) is not
> > > longer available on github (which makes recursive pull of submodules
> > > fail for a lot of people).
> > > Do you think we should do something on our side?
> >
> > Once EDK2 fix the problem, then QEMU can update its EDK2 submodule to
> > get the fix.
>
> Looks like the "EDK2 fix the problem" part has now happened:
>
> https://github.com/tianocore/edk2/commit/95d8a1c255cfb8e063d679930d08ca6426eb5701

And I see also that there is now an EDK2 tag edk2-stable202408.01
which is identical to the edk2-stable202408 tag we're currently
using except for having the submodule reference fixed.

Gerd, could you roll a patch which updates our EDK2 to
edk2-stable202408.01 , please?

(This has now been raised as
https://gitlab.com/qemu-project/qemu/-/issues/2660 --
obviously at least a subset of our users are in the habit
of pulling all submodules recursively, so it would be good
to update our submodule to have the fix.)

thanks
-- PMM