qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Eric Blake" <eblake@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Avihai Horon" <avihaih@nvidia.com>,
	"Joao Martins" <joao.m.martins@oracle.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v3 2/2] vfio/migration: Add vfio_save_block_precopy_empty_hit trace event
Date: Tue, 5 Nov 2024 10:20:35 -0500	[thread overview]
Message-ID: <Zyo3w6RdIr0nLV0t@x1n> (raw)
In-Reply-To: <d722992f-6886-4ad4-9d60-2acc61604739@redhat.com>

On Tue, Nov 05, 2024 at 01:51:31PM +0100, Cédric Le Goater wrote:
> On 11/5/24 13:20, Maciej S. Szmigiero wrote:
> > On 5.11.2024 08:56, Cédric Le Goater wrote:
> > > On 11/4/24 22:29, Maciej S. Szmigiero wrote:
> > > > From: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
> > > > 
> > > > This way it is clearly known when there's no more data to send for that
> > > > device.
> > > > 
> > > > Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
> > > > ---
> > > >   hw/vfio/migration.c           | 8 ++++++++
> > > >   hw/vfio/trace-events          | 1 +
> > > >   include/hw/vfio/vfio-common.h | 1 +
> > > >   3 files changed, 10 insertions(+)
> > > > 
> > > 
> > > Reviewed-by: Cédric Le Goater <clg@redhat.com>
> > 
> > Thanks, will you pick up these two patches or
> > is Peter supposed to do it?

When there's dependency, we can discuss how to merge. But I suppose all
standalone hw/vfio/* patches should by default go via Cédric.

> 
> I will send a small PR at the end of the day.

Thanks!

-- 
Peter Xu



      reply	other threads:[~2024-11-05 15:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 21:29 [PATCH v3 0/2] vfio/migration: new trace events for 9.2 Maciej S. Szmigiero
2024-11-04 21:29 ` [PATCH v3 1/2] vfio/migration: Add save_{iterate, complete_precopy}_start trace events Maciej S. Szmigiero
2024-11-05  7:55   ` [PATCH v3 1/2] vfio/migration: Add save_{iterate,complete_precopy}_start " Cédric Le Goater
2024-11-04 21:29 ` [PATCH v3 2/2] vfio/migration: Add vfio_save_block_precopy_empty_hit trace event Maciej S. Szmigiero
2024-11-05  7:56   ` Cédric Le Goater
2024-11-05 12:20     ` Maciej S. Szmigiero
2024-11-05 12:51       ` Cédric Le Goater
2024-11-05 15:20         ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zyo3w6RdIr0nLV0t@x1n \
    --to=peterx@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=eblake@redhat.com \
    --cc=farosas@suse.de \
    --cc=joao.m.martins@oracle.com \
    --cc=mail@maciej.szmigiero.name \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).