From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E463BD3610E for ; Tue, 5 Nov 2024 19:28:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8PDo-00042R-6y; Tue, 05 Nov 2024 14:28:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8PDi-000423-4H for qemu-devel@nongnu.org; Tue, 05 Nov 2024 14:28:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8PDg-0004bO-2p for qemu-devel@nongnu.org; Tue, 05 Nov 2024 14:28:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730834865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vz8jTkTRDD7Vvc2p0Qe1tnshcBMJGm3rZQ8IIQ3EAmc=; b=KwwgHJet1lUbeFFLXNOOa87apnF1PTdSLTRZjjUhPffGkpu8ZbXvEDF+7QScOzhntqRe1E eVOQP8mlURP3A8PfWWNV33ZD0/vM+LvkSsVKzD9uCZCsEl2h+p2z+DyBZTmGQ7b/sSvlXn 3jQm6q8JOWgkMa9Hlk03L0cIBwqxvnY= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-EeU98dPjPGGuccTGrRPbvg-1; Tue, 05 Nov 2024 14:27:42 -0500 X-MC-Unique: EeU98dPjPGGuccTGrRPbvg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1B4BC1955EAF; Tue, 5 Nov 2024 19:27:40 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.127]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A1A5E1955F40; Tue, 5 Nov 2024 19:27:37 +0000 (UTC) Date: Tue, 5 Nov 2024 20:27:28 +0100 From: Kevin Wolf To: Michael Tokarev Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org Subject: Re: [PATCH 01/27] qemu-img: measure: convert img_size to signed, simplify handling Message-ID: References: <20240927061121.573271-1-mjt@tls.msk.ru> <20240927061121.573271-2-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240927061121.573271-2-mjt@tls.msk.ru> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 27.09.2024 um 08:10 hat Michael Tokarev geschrieben: > qemu_opt_set_number() expects signed int64_t. > > Use int64_t instead of uint64_t for img_size, use -1 as "unset" > value instead of UINT64_MAX, and do not require temporary sval > for conversion from string. > > Signed-off-by: Michael Tokarev > Reviewed-by: Daniel P. Berrangé Reviewed-by: Kevin Wolf