From: Roman Bolshakov <roman@roolebo.dev>
To: Phil Dennis-Jordan <phil@philjordan.eu>
Cc: qemu-devel@nongnu.org, dirty@apple.com, rbolshakov@ddn.com,
pbonzini@redhat.com
Subject: Re: [PATCH 1/5] i386/hvf: Integrates x2APIC support with hvf accel
Date: Wed, 6 Nov 2024 17:44:20 +0700 [thread overview]
Message-ID: <ZytIhJDBtsAhPSKE@roolebo.dev> (raw)
In-Reply-To: <20241105155800.5461-2-phil@philjordan.eu>
On Tue, Nov 05, 2024 at 04:57:56PM +0100, Phil Dennis-Jordan wrote:
> Support for x2APIC mode was recently introduced in the software emulated
> APIC implementation for TCG. Enabling it when using macOS´s hvf
> accelerator is useful and significantly helps performance, as Qemu
> currently uses the emulated APIC when running on hvf as well.
>
> This change wires up the read & write operations for the MSR VM exits
> and allow-lists the CPUID flag in the x86 hvf runtime.
>
> Signed-off-by: Phil Dennis-Jordan <phil@philjordan.eu>
Reviewed-by: Roman Bolshakov <rbolshakov@ddn.com>
Hi Phil,
I don't observe any change in x2apic KVM unit tests with the patch.
I tried the single patch and the series, not looked into the test
failure yet.
Do you happen to know why?
Also what guest do you run? Desktop Ubuntu 24.04 doesn't seem to work
with x86 HVF.
Thanks,
Roman
next prev parent reply other threads:[~2024-11-06 10:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 15:57 [PATCH 0/5] i386/hvf: x2apic support and some small fixes Phil Dennis-Jordan
2024-11-05 15:57 ` [PATCH 1/5] i386/hvf: Integrates x2APIC support with hvf accel Phil Dennis-Jordan
2024-11-06 10:44 ` Roman Bolshakov [this message]
2024-11-05 15:57 ` [PATCH 2/5] i386/hvf: Fix for UB in handling CPUID function 0xD Phil Dennis-Jordan
2024-11-06 14:01 ` Roman Bolshakov
2024-11-05 15:57 ` [PATCH 3/5] i386/hvf: Fixes startup memory leak (vmcs caps) Phil Dennis-Jordan
2024-11-06 14:03 ` Roman Bolshakov
2024-11-05 15:57 ` [PATCH 4/5] i386/hvf: Raise exception on error setting APICBASE Phil Dennis-Jordan
2024-11-06 14:04 ` Roman Bolshakov
2024-11-05 15:58 ` [PATCH 5/5] i386/hvf: Removes duplicate/shadowed variables in hvf_vcpu_exec Phil Dennis-Jordan
2024-11-06 14:05 ` Roman Bolshakov
2024-11-06 15:26 ` [PATCH 0/5] i386/hvf: x2apic support and some small fixes Roman Bolshakov
2024-11-06 18:45 ` Phil Dennis-Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZytIhJDBtsAhPSKE@roolebo.dev \
--to=roman@roolebo.dev \
--cc=dirty@apple.com \
--cc=pbonzini@redhat.com \
--cc=phil@philjordan.eu \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).