Re: [PATCH 05/22] tests/qtest/migration: Move bootfile code to its own file

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Nov 05, 2024 at 03:08:20PM -0300, Fabiano Rosas wrote:
> Move the code that creates the guest binary out of migration-test and
> into the qtest/migration/ directory, along with the rest of the
> a-b-kernel code.
> 
> That code is part of the basic infrastructure of migration tests, it
> shouldn't be among the tests themselves.
> 
> Also take the chance and rename migration-test.h, which is too generic
> a name for this header which contains only values related to guest
> memory offsets.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>  tests/qtest/meson.build                       |  8 ++-
>  tests/qtest/migration-helpers.c               |  1 +
>  tests/qtest/migration-test.c                  | 58 +--------------
>  tests/qtest/migration/bootfile.c              | 70 +++++++++++++++++++
>  .../{migration-test.h => bootfile.h}          |  9 ++-
>  5 files changed, 86 insertions(+), 60 deletions(-)
>  create mode 100644 tests/qtest/migration/bootfile.c
>  rename tests/qtest/migration/{migration-test.h => bootfile.h} (85%)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|