Re: [PATCH 12/22] tests/qtest/migration: Split TLS tests from migration-test.c

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Nov 05, 2024 at 03:08:27PM -0300, Fabiano Rosas wrote:
> The migration-test.c file has become unwieldy large. It's quite
> confusing to navigate with all the test definitions mixed with hook
> definitions. The TLS tests make this worse with ifdef'ery.
> 
> Since we're planning on having a smaller set of tests to run as smoke
> testing on all architectures, I'm taking the time to split some tests
> into their own file.
> 
> Move the TLS tests into a file of their own.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>  tests/qtest/meson.build                  |   8 +-
>  tests/qtest/migration-test.c             | 788 +---------------------
>  tests/qtest/migration/migration-common.h |   6 +
>  tests/qtest/migration/tls-tests.c        | 790 +++++++++++++++++++++++
>  4 files changed, 803 insertions(+), 789 deletions(-)
>  create mode 100644 tests/qtest/migration/tls-tests.c


> diff --git a/tests/qtest/migration/migration-common.h b/tests/qtest/migration/migration-common.h
> index 8d0081c698..c546e92259 100644
> --- a/tests/qtest/migration/tls-tests.c
> +++ b/tests/qtest/migration/tls-tests.c


> +
> +void migration_test_add_tls(MigrationTestEnv *env)
> +{
> +    tmpfs = env->tmpfs;
> +
> +    migration_test_add("/migration/precopy/unix/tls/psk",
> +                       test_precopy_unix_tls_psk);
> +

...snip...

> +}

Looking at this, and considering the later patch which introduces
'make qtest-<subsystem>' support, I wonder if we actually need to
have a single 'migration-test' binary. Why not just add a main()
method to this  test-tests.c, and have a 'migration-test-tls'
binary ?

"make qtest-migration" would provoide a way to run the same level
of functionality seen when everything was in one 'migration-test'
binary.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|