From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22CCAD711CA for ; Thu, 21 Nov 2024 10:27:07 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tE4Of-0007ov-8r; Thu, 21 Nov 2024 05:26:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tE4Od-0007on-Ib for qemu-devel@nongnu.org; Thu, 21 Nov 2024 05:26:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tE4Oc-0002zO-2Y for qemu-devel@nongnu.org; Thu, 21 Nov 2024 05:26:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732184805; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aHSmgGeF04r+yCm3zLDyKeO9W6+I9EVOjZ9xhFhF5Sk=; b=Zo3JgjbBy6JIQy6L/Tb3BDwnr/97HrUw1AtTg4w163EKtey4mXtCEOIkNZuIruNKYnHSlu N7JT4QZM8hnK6HCpRGE/maFiCAwjWzpr9GGlgSpNLFRw4urLhP8X2N0JzM7W7Q0knXCnlL JvbqxNcepopG4d+MSMe0gWBxZhsuXM8= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-7QVlPK5zNyCqSwNu7YNJ8A-1; Thu, 21 Nov 2024 05:26:44 -0500 X-MC-Unique: 7QVlPK5zNyCqSwNu7YNJ8A-1 X-Mimecast-MFC-AGG-ID: 7QVlPK5zNyCqSwNu7YNJ8A Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B3F3419560BE; Thu, 21 Nov 2024 10:26:42 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EE87B1955F40; Thu, 21 Nov 2024 10:26:37 +0000 (UTC) Date: Thu, 21 Nov 2024 10:26:34 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Xu Cc: qemu-devel@nongnu.org, Eduardo Habkost , Peter Maydell , Markus Armbruster , Juraj Marcin , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?C=C3=A9dric?= Le Goater , Paolo Bonzini , Fabiano Rosas , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH 05/12] ui/console: Explicitly create "/backend" container Message-ID: References: <20241120215703.3918445-1-peterx@redhat.com> <20241120215703.3918445-6-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241120215703.3918445-6-peterx@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.143, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Nov 20, 2024 at 04:56:56PM -0500, Peter Xu wrote: > Follow the trend to explicitly create containers, do that for console.c on > "/backend" container. > > Cc: Marc-André Lureau > Signed-off-by: Peter Xu > --- > ui/console.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ui/console.c b/ui/console.c > index 5165f17125..36f8c6debb 100644 > --- a/ui/console.c > +++ b/ui/console.c > @@ -1154,14 +1154,14 @@ DisplayState *init_displaystate(void) > { > gchar *name; > QemuConsole *con; > + Object *backend = container_create(object_get_root(), "backend"); What's the rationale for keeping this in the console code ? I'd consider this to be a similar situation to '/chardevs' and '/objects', and be a common container rather than UI specific. IOW, be created by your later patch. > > QTAILQ_FOREACH(con, &consoles, next) { > /* Hook up into the qom tree here (not in object_new()), once > * all QemuConsoles are created and the order / numbering > * doesn't change any more */ > name = g_strdup_printf("console[%d]", con->index); > - object_property_add_child(container_get(object_get_root(), "/backend"), > - name, OBJECT(con)); > + object_property_add_child(backend, name, OBJECT(con)); > g_free(name); > } With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|