From: Zhao Liu <zhao1.liu@intel.com>
To: dongli.zhang@oracle.com
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, pbonzini@redhat.com,
mtosatti@redhat.com, sandipan.das@amd.com, babu.moger@amd.com,
likexu@tencent.com, like.xu.linux@gmail.com,
zhenyuw@linux.intel.com, groug@kaod.org, lyan@digitalocean.com,
khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com,
den@virtuozzo.com, joe.jin@oracle.com,
davydov-max@yandex-team.ru, dapeng1.mi@linux.intel.com,
zide.chen@intel.com
Subject: Re: [PATCH 2/7] target/i386/kvm: introduce 'pmu-cap-disabled' to set KVM_PMU_CAP_DISABLE
Date: Thu, 14 Nov 2024 01:15:09 +0800 [thread overview]
Message-ID: <ZzTenX8KOOGxZCou@intel.com> (raw)
In-Reply-To: <57b4b74d-67d2-4fcf-aa59-c788afc93619@oracle.com>
> > Further, considering that this is currently the only case that needs to
> > to set the VM level's capability in the CPU context, there is no need to
> > introduce a new kvm interface (in your previous patch), which can instead
> > be set in kvm_cpu_realizefn(), like:
> >
Now your case is not the only user of kvm_arch_pre_create_vcpu(), and
TDX also needs this [*]. So, this is the support for bringing back your
previous solution (preferably with comments, as I suggested earlier,
explaining why it's necessary to handle VM-level cap in the CPU
context). :-)
[*]: https://lore.kernel.org/qemu-devel/20241105062408.3533704-8-xiaoyao.li@intel.com/
next prev parent reply other threads:[~2024-11-13 16:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 9:40 [PATCH 0/7] target/i386/kvm/pmu: Enhancement, Bugfix and Cleanup Dongli Zhang
2024-11-04 9:40 ` [PATCH 1/7] target/i386: disable PerfMonV2 when PERFCORE unavailable Dongli Zhang
2024-11-06 3:54 ` Zhao Liu
2024-11-07 0:29 ` dongli.zhang
2024-11-07 7:57 ` Zhao Liu
2024-11-04 9:40 ` [PATCH 2/7] target/i386/kvm: introduce 'pmu-cap-disabled' to set KVM_PMU_CAP_DISABLE Dongli Zhang
2024-11-07 7:52 ` Zhao Liu
2024-11-07 23:44 ` dongli.zhang
2024-11-08 2:32 ` Zhao Liu
2024-11-08 12:52 ` Sandipan Das
2024-11-13 17:15 ` Zhao Liu [this message]
2024-11-14 0:13 ` dongli.zhang
2024-11-21 10:06 ` Mi, Dapeng
2025-02-07 9:52 ` Mi, Dapeng
2025-02-09 20:12 ` dongli.zhang
2025-02-10 8:04 ` Mi, Dapeng
2024-11-04 9:40 ` [PATCH 3/7] target/i386/kvm: init PMU information only once Dongli Zhang
2024-11-10 15:29 ` Zhao Liu
2024-11-13 1:50 ` dongli.zhang
2024-11-13 16:48 ` Zhao Liu
2024-11-04 9:40 ` [PATCH 4/7] target/i386/kvm: rename architectural PMU variables Dongli Zhang
2024-11-04 9:40 ` [PATCH 5/7] target/i386/kvm: reset AMD PMU registers during VM reset Dongli Zhang
2024-11-06 9:58 ` Sandipan Das
2024-11-07 0:33 ` dongli.zhang
2024-11-07 21:00 ` Maksim Davydov
2024-11-08 1:19 ` dongli.zhang
2024-11-08 14:07 ` Maksim Davydov
2024-11-08 18:04 ` dongli.zhang
2024-11-04 9:40 ` [PATCH 6/7] target/i386/kvm: support perfmon-v2 for reset Dongli Zhang
2024-11-08 13:09 ` Sandipan Das
2024-11-08 16:55 ` dongli.zhang
2024-11-04 9:40 ` [PATCH 7/7] target/i386/kvm: don't stop Intel PMU counters Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzTenX8KOOGxZCou@intel.com \
--to=zhao1.liu@intel.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=babu.moger@amd.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=davydov-max@yandex-team.ru \
--cc=den@virtuozzo.com \
--cc=dongli.zhang@oracle.com \
--cc=groug@kaod.org \
--cc=joe.jin@oracle.com \
--cc=khorenko@virtuozzo.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=likexu@tencent.com \
--cc=lyan@digitalocean.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sandipan.das@amd.com \
--cc=zhenyuw@linux.intel.com \
--cc=zide.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).