qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* QEMU wiki theme table of contents changes
@ 2024-11-14 10:50 Daniel P. Berrangé
  2024-11-14 19:04 ` Stefan Hajnoczi
  0 siblings, 1 reply; 9+ messages in thread
From: Daniel P. Berrangé @ 2024-11-14 10:50 UTC (permalink / raw)
  To: qemu-devel; +Cc: Stefan Hajnoczi, Paolo Bonzini

Looking at

  https://wiki.qemu.org/ChangeLog/9.2

I'm thinking that I'm sure there used to be a table of contents present
at the top of pages, but none is to be seen..... until I eventually
discover that there's a bare noticable, fully collapsed ToC in the left
hand nav panel below all the general wiki nav links, partially off the
bottom of the page :-(

If going to https://wiki.qemu.org/Special:Preferences, "Appearance" and
selecting "Vector legacy (2010)" as the "Skin" instad of "Vector (2022)"
then the full ToC re-appears at the top of page in the main body content.

I'm presuming this style change was triggered by a software upgrade that
was done on the wiki at some point.

IMHO this is quite a significant visual/usability regression.

On wikipedia, they do have the same theme, with ToC in the left hand
panel, but their ToC is expanded by default, and there's no other general
navigation in the left hand panel that's displacing the ToC off the bottom
of the page. That is fairly effective as a layout.

We can do something to the QEMU skin to improve this ? Swapping order
of the ToC & general nav blocks in the left hand panel would be a
improvement, as well making it expand at least 1 further level by
default.

If we're going to have background colour set for the general nav block,
we should also probably do similar for the ToC nav block to make it
visually stand out to the same degree.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: QEMU wiki theme table of contents changes
  2024-11-14 10:50 QEMU wiki theme table of contents changes Daniel P. Berrangé
@ 2024-11-14 19:04 ` Stefan Hajnoczi
  2024-11-15  8:54   ` Daniel P. Berrangé
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Hajnoczi @ 2024-11-14 19:04 UTC (permalink / raw)
  To: Daniel P. Berrangé; +Cc: qemu-devel, Stefan Hajnoczi, Paolo Bonzini

On Thu, 14 Nov 2024 at 05:51, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> Looking at
>
>   https://wiki.qemu.org/ChangeLog/9.2
>
> I'm thinking that I'm sure there used to be a table of contents present
> at the top of pages, but none is to be seen..... until I eventually
> discover that there's a bare noticable, fully collapsed ToC in the left
> hand nav panel below all the general wiki nav links, partially off the
> bottom of the page :-(
>
> If going to https://wiki.qemu.org/Special:Preferences, "Appearance" and
> selecting "Vector legacy (2010)" as the "Skin" instad of "Vector (2022)"
> then the full ToC re-appears at the top of page in the main body content.
>
> I'm presuming this style change was triggered by a software upgrade that
> was done on the wiki at some point.
>
> IMHO this is quite a significant visual/usability regression.
>
> On wikipedia, they do have the same theme, with ToC in the left hand
> panel, but their ToC is expanded by default, and there's no other general
> navigation in the left hand panel that's displacing the ToC off the bottom
> of the page. That is fairly effective as a layout.
>
> We can do something to the QEMU skin to improve this ? Swapping order
> of the ToC & general nav blocks in the left hand panel would be a
> improvement, as well making it expand at least 1 further level by
> default.
>
> If we're going to have background colour set for the general nav block,
> we should also probably do similar for the ToC nav block to make it
> visually stand out to the same degree.

Yes, that sounds good. The quickest would be for you to:
1. Run https://hub.docker.com/_/mediawiki/ in a container on your machine.
2. Adjust the theme CSS until you are happy.
3. Send me the tweaks and I will apply them to wiki.qemu.org.

If you don't have time, I'll add this to my todo list but no
guarantees when I'm able to do it.

Thanks,
Stefan


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: QEMU wiki theme table of contents changes
  2024-11-14 19:04 ` Stefan Hajnoczi
@ 2024-11-15  8:54   ` Daniel P. Berrangé
  2024-11-15 19:21     ` Stefan Hajnoczi
  0 siblings, 1 reply; 9+ messages in thread
From: Daniel P. Berrangé @ 2024-11-15  8:54 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: qemu-devel, Stefan Hajnoczi, Paolo Bonzini

On Thu, Nov 14, 2024 at 02:04:35PM -0500, Stefan Hajnoczi wrote:
> On Thu, 14 Nov 2024 at 05:51, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > Looking at
> >
> >   https://wiki.qemu.org/ChangeLog/9.2
> >
> > I'm thinking that I'm sure there used to be a table of contents present
> > at the top of pages, but none is to be seen..... until I eventually
> > discover that there's a bare noticable, fully collapsed ToC in the left
> > hand nav panel below all the general wiki nav links, partially off the
> > bottom of the page :-(
> >
> > If going to https://wiki.qemu.org/Special:Preferences, "Appearance" and
> > selecting "Vector legacy (2010)" as the "Skin" instad of "Vector (2022)"
> > then the full ToC re-appears at the top of page in the main body content.
> >
> > I'm presuming this style change was triggered by a software upgrade that
> > was done on the wiki at some point.
> >
> > IMHO this is quite a significant visual/usability regression.
> >
> > On wikipedia, they do have the same theme, with ToC in the left hand
> > panel, but their ToC is expanded by default, and there's no other general
> > navigation in the left hand panel that's displacing the ToC off the bottom
> > of the page. That is fairly effective as a layout.
> >
> > We can do something to the QEMU skin to improve this ? Swapping order
> > of the ToC & general nav blocks in the left hand panel would be a
> > improvement, as well making it expand at least 1 further level by
> > default.
> >
> > If we're going to have background colour set for the general nav block,
> > we should also probably do similar for the ToC nav block to make it
> > visually stand out to the same degree.
> 
> Yes, that sounds good. The quickest would be for you to:
> 1. Run https://hub.docker.com/_/mediawiki/ in a container on your machine.
> 2. Adjust the theme CSS until you are happy.
> 3. Send me the tweaks and I will apply them to wiki.qemu.org.

Is the current QEMU mediawiki code (or just theme) published anywhere
that I can base work off ?


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: QEMU wiki theme table of contents changes
  2024-11-15  8:54   ` Daniel P. Berrangé
@ 2024-11-15 19:21     ` Stefan Hajnoczi
  2024-11-15 19:38       ` Daniel P. Berrangé
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Hajnoczi @ 2024-11-15 19:21 UTC (permalink / raw)
  To: Daniel P. Berrangé; +Cc: qemu-devel, Stefan Hajnoczi, Paolo Bonzini

On Fri, 15 Nov 2024 at 03:54, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Thu, Nov 14, 2024 at 02:04:35PM -0500, Stefan Hajnoczi wrote:
> > On Thu, 14 Nov 2024 at 05:51, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > >
> > > Looking at
> > >
> > >   https://wiki.qemu.org/ChangeLog/9.2
> > >
> > > I'm thinking that I'm sure there used to be a table of contents present
> > > at the top of pages, but none is to be seen..... until I eventually
> > > discover that there's a bare noticable, fully collapsed ToC in the left
> > > hand nav panel below all the general wiki nav links, partially off the
> > > bottom of the page :-(
> > >
> > > If going to https://wiki.qemu.org/Special:Preferences, "Appearance" and
> > > selecting "Vector legacy (2010)" as the "Skin" instad of "Vector (2022)"
> > > then the full ToC re-appears at the top of page in the main body content.
> > >
> > > I'm presuming this style change was triggered by a software upgrade that
> > > was done on the wiki at some point.
> > >
> > > IMHO this is quite a significant visual/usability regression.
> > >
> > > On wikipedia, they do have the same theme, with ToC in the left hand
> > > panel, but their ToC is expanded by default, and there's no other general
> > > navigation in the left hand panel that's displacing the ToC off the bottom
> > > of the page. That is fairly effective as a layout.
> > >
> > > We can do something to the QEMU skin to improve this ? Swapping order
> > > of the ToC & general nav blocks in the left hand panel would be a
> > > improvement, as well making it expand at least 1 further level by
> > > default.
> > >
> > > If we're going to have background colour set for the general nav block,
> > > we should also probably do similar for the ToC nav block to make it
> > > visually stand out to the same degree.
> >
> > Yes, that sounds good. The quickest would be for you to:
> > 1. Run https://hub.docker.com/_/mediawiki/ in a container on your machine.
> > 2. Adjust the theme CSS until you are happy.
> > 3. Send me the tweaks and I will apply them to wiki.qemu.org.
>
> Is the current QEMU mediawiki code (or just theme) published anywhere
> that I can base work off ?

The QEMU wiki runs from the vanilla mediawiki 1.39 container image.
The Vector (2022) theme comes with Mediawiki and there are no
QEMU-specific customizations.

You can get the same look with the vanilla Mediawiki container image
with the following in LocalSettings.php:
$wgDefaultSkin = "vector-2022";
wfLoadSkin('Vector');

Sorry I am not able to fix this quickly myself. I don't have much
Mediawiki knowledge but if you tell me what to do we can certainly
customize QEMU's wiki.

Stefan


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: QEMU wiki theme table of contents changes
  2024-11-15 19:21     ` Stefan Hajnoczi
@ 2024-11-15 19:38       ` Daniel P. Berrangé
  2024-11-19 19:54         ` Stefan Hajnoczi
  0 siblings, 1 reply; 9+ messages in thread
From: Daniel P. Berrangé @ 2024-11-15 19:38 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: qemu-devel, Stefan Hajnoczi, Paolo Bonzini

On Fri, Nov 15, 2024 at 02:21:12PM -0500, Stefan Hajnoczi wrote:
> On Fri, 15 Nov 2024 at 03:54, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Thu, Nov 14, 2024 at 02:04:35PM -0500, Stefan Hajnoczi wrote:
> > > On Thu, 14 Nov 2024 at 05:51, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > >
> > > > Looking at
> > > >
> > > >   https://wiki.qemu.org/ChangeLog/9.2
> > > >
> > > > I'm thinking that I'm sure there used to be a table of contents present
> > > > at the top of pages, but none is to be seen..... until I eventually
> > > > discover that there's a bare noticable, fully collapsed ToC in the left
> > > > hand nav panel below all the general wiki nav links, partially off the
> > > > bottom of the page :-(
> > > >
> > > > If going to https://wiki.qemu.org/Special:Preferences, "Appearance" and
> > > > selecting "Vector legacy (2010)" as the "Skin" instad of "Vector (2022)"
> > > > then the full ToC re-appears at the top of page in the main body content.
> > > >
> > > > I'm presuming this style change was triggered by a software upgrade that
> > > > was done on the wiki at some point.
> > > >
> > > > IMHO this is quite a significant visual/usability regression.
> > > >
> > > > On wikipedia, they do have the same theme, with ToC in the left hand
> > > > panel, but their ToC is expanded by default, and there's no other general
> > > > navigation in the left hand panel that's displacing the ToC off the bottom
> > > > of the page. That is fairly effective as a layout.
> > > >
> > > > We can do something to the QEMU skin to improve this ? Swapping order
> > > > of the ToC & general nav blocks in the left hand panel would be a
> > > > improvement, as well making it expand at least 1 further level by
> > > > default.
> > > >
> > > > If we're going to have background colour set for the general nav block,
> > > > we should also probably do similar for the ToC nav block to make it
> > > > visually stand out to the same degree.
> > >
> > > Yes, that sounds good. The quickest would be for you to:
> > > 1. Run https://hub.docker.com/_/mediawiki/ in a container on your machine.
> > > 2. Adjust the theme CSS until you are happy.
> > > 3. Send me the tweaks and I will apply them to wiki.qemu.org.
> >
> > Is the current QEMU mediawiki code (or just theme) published anywhere
> > that I can base work off ?
> 
> The QEMU wiki runs from the vanilla mediawiki 1.39 container image.
> The Vector (2022) theme comes with Mediawiki and there are no
> QEMU-specific customizations.
> 
> You can get the same look with the vanilla Mediawiki container image
> with the following in LocalSettings.php:
> $wgDefaultSkin = "vector-2022";
> wfLoadSkin('Vector');

Hmm, I'm wondering where the QEMU specific left nav bar content
and styling comes from then... ? 

> 
> Sorry I am not able to fix this quickly myself. I don't have much
> Mediawiki knowledge but if you tell me what to do we can certainly
> customize QEMU's wiki.
> 
> Stefan
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: QEMU wiki theme table of contents changes
  2024-11-15 19:38       ` Daniel P. Berrangé
@ 2024-11-19 19:54         ` Stefan Hajnoczi
  2024-11-21 15:48           ` Daniel P. Berrangé
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Hajnoczi @ 2024-11-19 19:54 UTC (permalink / raw)
  To: Daniel P. Berrangé; +Cc: Stefan Hajnoczi, qemu-devel, Paolo Bonzini

[-- Attachment #1: Type: text/plain, Size: 3311 bytes --]

On Fri, Nov 15, 2024 at 07:38:06PM +0000, Daniel P. Berrangé wrote:
> On Fri, Nov 15, 2024 at 02:21:12PM -0500, Stefan Hajnoczi wrote:
> > On Fri, 15 Nov 2024 at 03:54, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > >
> > > On Thu, Nov 14, 2024 at 02:04:35PM -0500, Stefan Hajnoczi wrote:
> > > > On Thu, 14 Nov 2024 at 05:51, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > > >
> > > > > Looking at
> > > > >
> > > > >   https://wiki.qemu.org/ChangeLog/9.2
> > > > >
> > > > > I'm thinking that I'm sure there used to be a table of contents present
> > > > > at the top of pages, but none is to be seen..... until I eventually
> > > > > discover that there's a bare noticable, fully collapsed ToC in the left
> > > > > hand nav panel below all the general wiki nav links, partially off the
> > > > > bottom of the page :-(
> > > > >
> > > > > If going to https://wiki.qemu.org/Special:Preferences, "Appearance" and
> > > > > selecting "Vector legacy (2010)" as the "Skin" instad of "Vector (2022)"
> > > > > then the full ToC re-appears at the top of page in the main body content.
> > > > >
> > > > > I'm presuming this style change was triggered by a software upgrade that
> > > > > was done on the wiki at some point.
> > > > >
> > > > > IMHO this is quite a significant visual/usability regression.
> > > > >
> > > > > On wikipedia, they do have the same theme, with ToC in the left hand
> > > > > panel, but their ToC is expanded by default, and there's no other general
> > > > > navigation in the left hand panel that's displacing the ToC off the bottom
> > > > > of the page. That is fairly effective as a layout.
> > > > >
> > > > > We can do something to the QEMU skin to improve this ? Swapping order
> > > > > of the ToC & general nav blocks in the left hand panel would be a
> > > > > improvement, as well making it expand at least 1 further level by
> > > > > default.
> > > > >
> > > > > If we're going to have background colour set for the general nav block,
> > > > > we should also probably do similar for the ToC nav block to make it
> > > > > visually stand out to the same degree.
> > > >
> > > > Yes, that sounds good. The quickest would be for you to:
> > > > 1. Run https://hub.docker.com/_/mediawiki/ in a container on your machine.
> > > > 2. Adjust the theme CSS until you are happy.
> > > > 3. Send me the tweaks and I will apply them to wiki.qemu.org.
> > >
> > > Is the current QEMU mediawiki code (or just theme) published anywhere
> > > that I can base work off ?
> > 
> > The QEMU wiki runs from the vanilla mediawiki 1.39 container image.
> > The Vector (2022) theme comes with Mediawiki and there are no
> > QEMU-specific customizations.
> > 
> > You can get the same look with the vanilla Mediawiki container image
> > with the following in LocalSettings.php:
> > $wgDefaultSkin = "vector-2022";
> > wfLoadSkin('Vector');
> 
> Hmm, I'm wondering where the QEMU specific left nav bar content
> and styling comes from then... ? 

I'm not sure but unless there is something stored in the database, I
can't imagine any customizations because there aren't any config files,
themes, CSS overrides, etc to speak of in QEMU's MediaWiki installation.
It's just running the vanilla container image.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: QEMU wiki theme table of contents changes
  2024-11-19 19:54         ` Stefan Hajnoczi
@ 2024-11-21 15:48           ` Daniel P. Berrangé
  2024-12-04 21:26             ` Stefan Hajnoczi
  0 siblings, 1 reply; 9+ messages in thread
From: Daniel P. Berrangé @ 2024-11-21 15:48 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: Stefan Hajnoczi, qemu-devel, Paolo Bonzini

On Tue, Nov 19, 2024 at 02:54:29PM -0500, Stefan Hajnoczi wrote:
> On Fri, Nov 15, 2024 at 07:38:06PM +0000, Daniel P. Berrangé wrote:
> > On Fri, Nov 15, 2024 at 02:21:12PM -0500, Stefan Hajnoczi wrote:
> > > On Fri, 15 Nov 2024 at 03:54, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > >
> > > > On Thu, Nov 14, 2024 at 02:04:35PM -0500, Stefan Hajnoczi wrote:
> > > > > On Thu, 14 Nov 2024 at 05:51, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > > > >
> > > > > > Looking at
> > > > > >
> > > > > >   https://wiki.qemu.org/ChangeLog/9.2
> > > > > >
> > > > > > I'm thinking that I'm sure there used to be a table of contents present
> > > > > > at the top of pages, but none is to be seen..... until I eventually
> > > > > > discover that there's a bare noticable, fully collapsed ToC in the left
> > > > > > hand nav panel below all the general wiki nav links, partially off the
> > > > > > bottom of the page :-(
> > > > > >
> > > > > > If going to https://wiki.qemu.org/Special:Preferences, "Appearance" and
> > > > > > selecting "Vector legacy (2010)" as the "Skin" instad of "Vector (2022)"
> > > > > > then the full ToC re-appears at the top of page in the main body content.
> > > > > >
> > > > > > I'm presuming this style change was triggered by a software upgrade that
> > > > > > was done on the wiki at some point.
> > > > > >
> > > > > > IMHO this is quite a significant visual/usability regression.
> > > > > >
> > > > > > On wikipedia, they do have the same theme, with ToC in the left hand
> > > > > > panel, but their ToC is expanded by default, and there's no other general
> > > > > > navigation in the left hand panel that's displacing the ToC off the bottom
> > > > > > of the page. That is fairly effective as a layout.
> > > > > >
> > > > > > We can do something to the QEMU skin to improve this ? Swapping order
> > > > > > of the ToC & general nav blocks in the left hand panel would be a
> > > > > > improvement, as well making it expand at least 1 further level by
> > > > > > default.
> > > > > >
> > > > > > If we're going to have background colour set for the general nav block,
> > > > > > we should also probably do similar for the ToC nav block to make it
> > > > > > visually stand out to the same degree.
> > > > >
> > > > > Yes, that sounds good. The quickest would be for you to:
> > > > > 1. Run https://hub.docker.com/_/mediawiki/ in a container on your machine.
> > > > > 2. Adjust the theme CSS until you are happy.
> > > > > 3. Send me the tweaks and I will apply them to wiki.qemu.org.
> > > >
> > > > Is the current QEMU mediawiki code (or just theme) published anywhere
> > > > that I can base work off ?
> > > 
> > > The QEMU wiki runs from the vanilla mediawiki 1.39 container image.
> > > The Vector (2022) theme comes with Mediawiki and there are no
> > > QEMU-specific customizations.
> > > 
> > > You can get the same look with the vanilla Mediawiki container image
> > > with the following in LocalSettings.php:
> > > $wgDefaultSkin = "vector-2022";
> > > wfLoadSkin('Vector');
> > 
> > Hmm, I'm wondering where the QEMU specific left nav bar content
> > and styling comes from then... ? 
> 
> I'm not sure but unless there is something stored in the database, I
> can't imagine any customizations because there aren't any config files,
> themes, CSS overrides, etc to speak of in QEMU's MediaWiki installation.
> It's just running the vanilla container image.

Ah, I found out  we've done it with the side-bar addon

  https://wiki.qemu.org/MediaWiki:Sidebar


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: QEMU wiki theme table of contents changes
  2024-11-21 15:48           ` Daniel P. Berrangé
@ 2024-12-04 21:26             ` Stefan Hajnoczi
  2024-12-05 11:56               ` Daniel P. Berrangé
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Hajnoczi @ 2024-12-04 21:26 UTC (permalink / raw)
  To: Daniel P. Berrangé; +Cc: Stefan Hajnoczi, qemu-devel, Paolo Bonzini

[-- Attachment #1: Type: text/plain, Size: 3872 bytes --]

On Thu, Nov 21, 2024 at 03:48:12PM +0000, Daniel P. Berrangé wrote:
> On Tue, Nov 19, 2024 at 02:54:29PM -0500, Stefan Hajnoczi wrote:
> > On Fri, Nov 15, 2024 at 07:38:06PM +0000, Daniel P. Berrangé wrote:
> > > On Fri, Nov 15, 2024 at 02:21:12PM -0500, Stefan Hajnoczi wrote:
> > > > On Fri, 15 Nov 2024 at 03:54, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > > >
> > > > > On Thu, Nov 14, 2024 at 02:04:35PM -0500, Stefan Hajnoczi wrote:
> > > > > > On Thu, 14 Nov 2024 at 05:51, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > > > > >
> > > > > > > Looking at
> > > > > > >
> > > > > > >   https://wiki.qemu.org/ChangeLog/9.2
> > > > > > >
> > > > > > > I'm thinking that I'm sure there used to be a table of contents present
> > > > > > > at the top of pages, but none is to be seen..... until I eventually
> > > > > > > discover that there's a bare noticable, fully collapsed ToC in the left
> > > > > > > hand nav panel below all the general wiki nav links, partially off the
> > > > > > > bottom of the page :-(
> > > > > > >
> > > > > > > If going to https://wiki.qemu.org/Special:Preferences, "Appearance" and
> > > > > > > selecting "Vector legacy (2010)" as the "Skin" instad of "Vector (2022)"
> > > > > > > then the full ToC re-appears at the top of page in the main body content.
> > > > > > >
> > > > > > > I'm presuming this style change was triggered by a software upgrade that
> > > > > > > was done on the wiki at some point.
> > > > > > >
> > > > > > > IMHO this is quite a significant visual/usability regression.
> > > > > > >
> > > > > > > On wikipedia, they do have the same theme, with ToC in the left hand
> > > > > > > panel, but their ToC is expanded by default, and there's no other general
> > > > > > > navigation in the left hand panel that's displacing the ToC off the bottom
> > > > > > > of the page. That is fairly effective as a layout.
> > > > > > >
> > > > > > > We can do something to the QEMU skin to improve this ? Swapping order
> > > > > > > of the ToC & general nav blocks in the left hand panel would be a
> > > > > > > improvement, as well making it expand at least 1 further level by
> > > > > > > default.
> > > > > > >
> > > > > > > If we're going to have background colour set for the general nav block,
> > > > > > > we should also probably do similar for the ToC nav block to make it
> > > > > > > visually stand out to the same degree.
> > > > > >
> > > > > > Yes, that sounds good. The quickest would be for you to:
> > > > > > 1. Run https://hub.docker.com/_/mediawiki/ in a container on your machine.
> > > > > > 2. Adjust the theme CSS until you are happy.
> > > > > > 3. Send me the tweaks and I will apply them to wiki.qemu.org.
> > > > >
> > > > > Is the current QEMU mediawiki code (or just theme) published anywhere
> > > > > that I can base work off ?
> > > > 
> > > > The QEMU wiki runs from the vanilla mediawiki 1.39 container image.
> > > > The Vector (2022) theme comes with Mediawiki and there are no
> > > > QEMU-specific customizations.
> > > > 
> > > > You can get the same look with the vanilla Mediawiki container image
> > > > with the following in LocalSettings.php:
> > > > $wgDefaultSkin = "vector-2022";
> > > > wfLoadSkin('Vector');
> > > 
> > > Hmm, I'm wondering where the QEMU specific left nav bar content
> > > and styling comes from then... ? 
> > 
> > I'm not sure but unless there is something stored in the database, I
> > can't imagine any customizations because there aren't any config files,
> > themes, CSS overrides, etc to speak of in QEMU's MediaWiki installation.
> > It's just running the vanilla container image.
> 
> Ah, I found out  we've done it with the side-bar addon
> 
>   https://wiki.qemu.org/MediaWiki:Sidebar

Is there a fix I can apply to the wiki configuration?

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: QEMU wiki theme table of contents changes
  2024-12-04 21:26             ` Stefan Hajnoczi
@ 2024-12-05 11:56               ` Daniel P. Berrangé
  0 siblings, 0 replies; 9+ messages in thread
From: Daniel P. Berrangé @ 2024-12-05 11:56 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: Stefan Hajnoczi, qemu-devel, Paolo Bonzini

On Wed, Dec 04, 2024 at 04:26:19PM -0500, Stefan Hajnoczi wrote:
> On Thu, Nov 21, 2024 at 03:48:12PM +0000, Daniel P. Berrangé wrote:
> > On Tue, Nov 19, 2024 at 02:54:29PM -0500, Stefan Hajnoczi wrote:
> > > On Fri, Nov 15, 2024 at 07:38:06PM +0000, Daniel P. Berrangé wrote:
> > > > On Fri, Nov 15, 2024 at 02:21:12PM -0500, Stefan Hajnoczi wrote:
> > > > > On Fri, 15 Nov 2024 at 03:54, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > > > >
> > > > > > On Thu, Nov 14, 2024 at 02:04:35PM -0500, Stefan Hajnoczi wrote:
> > > > > > > On Thu, 14 Nov 2024 at 05:51, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > > > > > >
> > > > > > > > Looking at
> > > > > > > >
> > > > > > > >   https://wiki.qemu.org/ChangeLog/9.2
> > > > > > > >
> > > > > > > > I'm thinking that I'm sure there used to be a table of contents present
> > > > > > > > at the top of pages, but none is to be seen..... until I eventually
> > > > > > > > discover that there's a bare noticable, fully collapsed ToC in the left
> > > > > > > > hand nav panel below all the general wiki nav links, partially off the
> > > > > > > > bottom of the page :-(
> > > > > > > >
> > > > > > > > If going to https://wiki.qemu.org/Special:Preferences, "Appearance" and
> > > > > > > > selecting "Vector legacy (2010)" as the "Skin" instad of "Vector (2022)"
> > > > > > > > then the full ToC re-appears at the top of page in the main body content.
> > > > > > > >
> > > > > > > > I'm presuming this style change was triggered by a software upgrade that
> > > > > > > > was done on the wiki at some point.
> > > > > > > >
> > > > > > > > IMHO this is quite a significant visual/usability regression.
> > > > > > > >
> > > > > > > > On wikipedia, they do have the same theme, with ToC in the left hand
> > > > > > > > panel, but their ToC is expanded by default, and there's no other general
> > > > > > > > navigation in the left hand panel that's displacing the ToC off the bottom
> > > > > > > > of the page. That is fairly effective as a layout.
> > > > > > > >
> > > > > > > > We can do something to the QEMU skin to improve this ? Swapping order
> > > > > > > > of the ToC & general nav blocks in the left hand panel would be a
> > > > > > > > improvement, as well making it expand at least 1 further level by
> > > > > > > > default.
> > > > > > > >
> > > > > > > > If we're going to have background colour set for the general nav block,
> > > > > > > > we should also probably do similar for the ToC nav block to make it
> > > > > > > > visually stand out to the same degree.
> > > > > > >
> > > > > > > Yes, that sounds good. The quickest would be for you to:
> > > > > > > 1. Run https://hub.docker.com/_/mediawiki/ in a container on your machine.
> > > > > > > 2. Adjust the theme CSS until you are happy.
> > > > > > > 3. Send me the tweaks and I will apply them to wiki.qemu.org.
> > > > > >
> > > > > > Is the current QEMU mediawiki code (or just theme) published anywhere
> > > > > > that I can base work off ?
> > > > > 
> > > > > The QEMU wiki runs from the vanilla mediawiki 1.39 container image.
> > > > > The Vector (2022) theme comes with Mediawiki and there are no
> > > > > QEMU-specific customizations.
> > > > > 
> > > > > You can get the same look with the vanilla Mediawiki container image
> > > > > with the following in LocalSettings.php:
> > > > > $wgDefaultSkin = "vector-2022";
> > > > > wfLoadSkin('Vector');
> > > > 
> > > > Hmm, I'm wondering where the QEMU specific left nav bar content
> > > > and styling comes from then... ? 
> > > 
> > > I'm not sure but unless there is something stored in the database, I
> > > can't imagine any customizations because there aren't any config files,
> > > themes, CSS overrides, etc to speak of in QEMU's MediaWiki installation.
> > > It's just running the vanilla container image.
> > 
> > Ah, I found out  we've done it with the side-bar addon
> > 
> >   https://wiki.qemu.org/MediaWiki:Sidebar
> 
> Is there a fix I can apply to the wiki configuration?

Not yet, as I've not been able to make time to fully investigate and
work on this.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-12-05 11:57 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-14 10:50 QEMU wiki theme table of contents changes Daniel P. Berrangé
2024-11-14 19:04 ` Stefan Hajnoczi
2024-11-15  8:54   ` Daniel P. Berrangé
2024-11-15 19:21     ` Stefan Hajnoczi
2024-11-15 19:38       ` Daniel P. Berrangé
2024-11-19 19:54         ` Stefan Hajnoczi
2024-11-21 15:48           ` Daniel P. Berrangé
2024-12-04 21:26             ` Stefan Hajnoczi
2024-12-05 11:56               ` Daniel P. Berrangé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).