From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D410CD68B33 for ; Thu, 14 Nov 2024 16:13:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBcOH-00054v-KK; Thu, 14 Nov 2024 11:08:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBcM2-0002Ki-Rk for qemu-devel@nongnu.org; Thu, 14 Nov 2024 11:06:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBcLy-0003DE-PB for qemu-devel@nongnu.org; Thu, 14 Nov 2024 11:05:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731600350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YBEJaiHt3W1gvBSnRMJsLsnuY8HEgsh+w64nh+jJTE8=; b=W8cndow7NYTBXJ6ExH0VaV/mkQlPZnHGc7PRfxD1BC9XJalgzAp+1rsUOfmc396XpI28wz iNoo+Zg54fYHIRt4WP8ThrqTaxe6X+91VrVvY2QdKzVLTnVjmIDGnFfBHl5g6+28LrRiI6 bYOdNWFAF31B24sfeTdsCIvt6nwtB6k= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-qc8JZ9qPPrKmhkrF28h35w-1; Thu, 14 Nov 2024 11:05:46 -0500 X-MC-Unique: qc8JZ9qPPrKmhkrF28h35w-1 X-Mimecast-MFC-AGG-ID: qc8JZ9qPPrKmhkrF28h35w Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CEAA11955F43; Thu, 14 Nov 2024 16:05:45 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.6]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 52D82196BC05; Thu, 14 Nov 2024 16:05:42 +0000 (UTC) Date: Thu, 14 Nov 2024 17:05:40 +0100 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Eduardo Habkost , pkrempa@redhat.com, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Paolo Bonzini , armbru@redhat.com Subject: Re: [PATCH v3 0/2] qdev-monitor: avoid QemuOpts in QMP device_add() Message-ID: References: <20240827192751.948633-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827192751.948633-1-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.122, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 27.08.2024 um 21:27 hat Stefan Hajnoczi geschrieben: > v3: > - Duplicate drain_call_rcu() into hmp_device_add() because moving it into > qdev_device_add_from_qdict turned out to be unsafe. > v2: > - Rename Patch 1 to indicate that we're avoiding QemuOpts rather than doing a > full conversion to QAPI. Also mention that 'gen': false is still being used. > [Markus] > - Add Patch 2 to address a TODO comment suggesting that > qemu_create_cli_devices() should call qmp_device_add(). [Markus] > - Move drain_call_rcu() into qdev_device_add_from_qdict() to avoid code > duplication. [Markus] > > This series enables non-scalar parameter parsing in device_add (e.g. > virtio-blk-pci,iothread-vq-mapping=). Stop converting from QDict to QemuOpts > and back again as this loses type information and cannot represent non-scalars. Thanks, applied to the block branch. Kevin