Re: QEMU wiki theme table of contents changes

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Nov 15, 2024 at 02:21:12PM -0500, Stefan Hajnoczi wrote:
> On Fri, 15 Nov 2024 at 03:54, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Thu, Nov 14, 2024 at 02:04:35PM -0500, Stefan Hajnoczi wrote:
> > > On Thu, 14 Nov 2024 at 05:51, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > >
> > > > Looking at
> > > >
> > > >   https://wiki.qemu.org/ChangeLog/9.2
> > > >
> > > > I'm thinking that I'm sure there used to be a table of contents present
> > > > at the top of pages, but none is to be seen..... until I eventually
> > > > discover that there's a bare noticable, fully collapsed ToC in the left
> > > > hand nav panel below all the general wiki nav links, partially off the
> > > > bottom of the page :-(
> > > >
> > > > If going to https://wiki.qemu.org/Special:Preferences, "Appearance" and
> > > > selecting "Vector legacy (2010)" as the "Skin" instad of "Vector (2022)"
> > > > then the full ToC re-appears at the top of page in the main body content.
> > > >
> > > > I'm presuming this style change was triggered by a software upgrade that
> > > > was done on the wiki at some point.
> > > >
> > > > IMHO this is quite a significant visual/usability regression.
> > > >
> > > > On wikipedia, they do have the same theme, with ToC in the left hand
> > > > panel, but their ToC is expanded by default, and there's no other general
> > > > navigation in the left hand panel that's displacing the ToC off the bottom
> > > > of the page. That is fairly effective as a layout.
> > > >
> > > > We can do something to the QEMU skin to improve this ? Swapping order
> > > > of the ToC & general nav blocks in the left hand panel would be a
> > > > improvement, as well making it expand at least 1 further level by
> > > > default.
> > > >
> > > > If we're going to have background colour set for the general nav block,
> > > > we should also probably do similar for the ToC nav block to make it
> > > > visually stand out to the same degree.
> > >
> > > Yes, that sounds good. The quickest would be for you to:
> > > 1. Run https://hub.docker.com/_/mediawiki/ in a container on your machine.
> > > 2. Adjust the theme CSS until you are happy.
> > > 3. Send me the tweaks and I will apply them to wiki.qemu.org.
> >
> > Is the current QEMU mediawiki code (or just theme) published anywhere
> > that I can base work off ?
> 
> The QEMU wiki runs from the vanilla mediawiki 1.39 container image.
> The Vector (2022) theme comes with Mediawiki and there are no
> QEMU-specific customizations.
> 
> You can get the same look with the vanilla Mediawiki container image
> with the following in LocalSettings.php:
> $wgDefaultSkin = "vector-2022";
> wfLoadSkin('Vector');

Hmm, I'm wondering where the QEMU specific left nav bar content
and styling comes from then... ? 

> 
> Sorry I am not able to fix this quickly myself. I don't have much
> Mediawiki knowledge but if you tell me what to do we can certainly
> customize QEMU's wiki.
> 
> Stefan
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|