From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjo1-0006D7-6E for qemu-devel@nongnu.org; Wed, 22 Jun 2016 11:11:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFjo0-0008Nv-45 for qemu-devel@nongnu.org; Wed, 22 Jun 2016 11:11:05 -0400 References: <1464928382-9650-1-git-send-email-famz@redhat.com> <1464928382-9650-2-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: Date: Wed, 22 Jun 2016 17:10:52 +0200 MIME-Version: 1.0 In-Reply-To: <1464928382-9650-2-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IdH18NLbVc9f19xprHKVAlxBuhcAfH1v3" Subject: Re: [Qemu-devel] [PATCH v5 01/10] block: Hide HBitmap in block dirty bitmap interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IdH18NLbVc9f19xprHKVAlxBuhcAfH1v3 From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, qemu-block@nongnu.org Message-ID: Subject: Re: [PATCH v5 01/10] block: Hide HBitmap in block dirty bitmap interface References: <1464928382-9650-1-git-send-email-famz@redhat.com> <1464928382-9650-2-git-send-email-famz@redhat.com> In-Reply-To: <1464928382-9650-2-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 03.06.2016 06:32, Fam Zheng wrote: > HBitmap is an implementation detail of block dirty bitmap that should b= e hidden > from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlyi= ng > HBitmapIter. >=20 > A small difference in the interface is, before, an HBitmapIter is initi= alized > in place, now the new BdrvDirtyBitmapIter must be dynamically allocated= because > the structure definition is in block/dirty-bitmap.c. >=20 > Two current users are converted too. >=20 > Signed-off-by: Fam Zheng > --- > block/backup.c | 14 ++++++++------ > block/dirty-bitmap.c | 39 +++++++++++++++++++++++++++++++++---= --- > block/mirror.c | 24 +++++++++++++----------- > include/block/dirty-bitmap.h | 7 +++++-- > include/qemu/typedefs.h | 1 + > 5 files changed, 60 insertions(+), 25 deletions(-) Reviewed-by: Max Reitz --IdH18NLbVc9f19xprHKVAlxBuhcAfH1v3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXaqp9AAoJEDuxQgLoOKytEvgH/jhLS8VQnhhxavBasNlmo5sN 6nT8WESJ7maHcz5bGWmXIPtSxihijawL3bLO9C7xf0UGPb4amPW7hrHjUiVW86R1 +rCUCFHoGDSmXeMs08nzzyJqiT/hm4/TghYOhjfP5AbGyuwLjgavHf4ZE4X4WW6y 4/QuJELP+0TcXqxAwmHcL0w+z3uh+rR2KJ1lfxQpsY2Fjd9rEvVYEQwUtZLYwhHF vS79YE/PfBzg9QD72xM6jUxuHIggyYBGnpnITndEQDYg+BZ3y6dHeTHmwOQv9YiH ZovMD3gq95h9+GNUni285cV7rmHuG5+aw6Ic22jMjo1gdC8FyG9leJz7lEGRNaw= =OAMN -----END PGP SIGNATURE----- --IdH18NLbVc9f19xprHKVAlxBuhcAfH1v3--